Skip to content

Feature/header interaction#2

Merged
komodgn merged 2 commits into
developfrom
feature/header-interaction
Apr 27, 2026
Merged

Feature/header interaction#2
komodgn merged 2 commits into
developfrom
feature/header-interaction

Conversation

@komodgn

@komodgn komodgn commented Apr 27, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features

    • Calendar header is now clickable, triggering a notification with the selected month and year.
  • Style

    • Introduced neon color palette (NeonSky, NeonRed, NeonYellow) for enhanced visual identity.
    • Improved edge-to-edge rendering on Android devices.
    • Refined UI layout, spacing, and typography for better visual presentation.

@coderabbitai

coderabbitai Bot commented Apr 27, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e257176d-50c8-4cf9-8221-cc22ddc74cf7

📥 Commits

Reviewing files that changed from the base of the PR and between 3b39a4b and dea049c.

⛔ Files ignored due to path filters (1)
  • kotlin-js-store/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (5)
  • calendar-ui/src/commonMain/kotlin/io/github/komodgn/kmp/calendar/ui/MetaCalendar.kt
  • composeApp/src/androidMain/kotlin/io/github/komodgn/kmp/MainActivity.kt
  • composeApp/src/commonMain/kotlin/io/github/komodgn/kmp/App.kt
  • composeApp/src/commonMain/kotlin/io/github/komodgn/kmp/DemoLandingPage.kt
  • composeApp/src/commonMain/kotlin/io/github/komodgn/kmp/Theme.kt

📝 Walkthrough

Walkthrough

This pull request adds a new onHeaderClick callback to the MetaCalendar component, integrates it through the app's landing page, enables edge-to-edge rendering on Android, adjusts scaffold insets and snackbar messaging, and introduces new neon color constants to the theme system.

Changes

Cohort / File(s) Summary
Calendar Component Enhancement
calendar-ui/.../MetaCalendar.kt
Introduces onHeaderClick callback parameter; makes both header Text components clickable to trigger the callback with current (year, month) values, using Modifier.clickable() with suppressed ripple effects.
App Integration & Layout
composeApp/src/commonMain/kotlin/io/github/komodgn/kmp/App.kt, composeApp/src/commonMain/kotlin/io/github/komodgn/kmp/DemoLandingPage.kt
App.kt disables Scaffold content window insets and modifies snackbar message to exclude prefix. DemoLandingPage.kt accepts new onHeaderClick callback and forwards it to MetaCalendar; adjusts layout with status bar padding, updated header text, and refined spacing.
Theme System
composeApp/src/commonMain/kotlin/io/github/komodgn/kmp/Theme.kt
Adds three new neon color constants (NeonRed, NeonYellow, NeonSky) and updates dark M3 color scheme to use NeonSky as primary color with NeonRed-based container colors.
Android Platform Configuration
composeApp/src/androidMain/kotlin/io/github/komodgn/kmp/MainActivity.kt
Enables edge-to-edge rendering with explicit SystemBarStyle configuration for both status bar and navigation bar with dark variants and transparent backgrounds.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A hop, a click, a calendar dressed—
Headers now respond to every press!
Neon colors dance in the darkened night,
Edge-to-edge views shine crisp and bright,
One callback thread weaves it all just right! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/header-interaction

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@komodgn komodgn merged commit 6a1a4a1 into develop Apr 27, 2026
1 check was pending
@komodgn komodgn deleted the feature/header-interaction branch April 27, 2026 15:25
This was referenced Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant