This repository was archived by the owner on Nov 27, 2024. It is now read-only.
build(deps): bump the ginkgo group across 2 directories with 1 update#282
Merged
openshift-merge-bot[bot] merged 1 commit intomainfrom Sep 3, 2024
Conversation
dependabot
bot
added
dependencies
filariow
added a commit
to filariow/workspaces
that referenced
this pull request
Sep 2, 2024
This change wants to force the update of `e2e`'s indirect dependencies related to ginkgo and gomega when they are updated in `operator`. Look at konflux-workspaces#282 and konflux-workspaces#283 for examples of the problem. When gomega or ginkgo are updated in `operator`, they are not updated in `e2e` as they are indirect dependencies. As a consequence the build fails due to untidied gomod. Alternatively, we can add ginkgo and gomega as `e2e`'s direct dependencies. I think it would be good to start using gomega `e2e`, but I don't see space for ginkgo at the moment. Signed-off-by: Francesco Ilario <filario@redhat.com>
Bumps the ginkgo group with 1 update in the /operator directory: [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo). Bumps the ginkgo group with 1 update in the /server directory: [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo). Updates `github.com/onsi/ginkgo/v2` from 2.20.1 to 2.20.2 - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.20.1...v2.20.2) Updates `github.com/onsi/ginkgo/v2` from 2.20.1 to 2.20.2 - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.20.1...v2.20.2) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: ginkgo - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: ginkgo ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/operator/ginkgo-217d1f6e29
branch
from
65017b0 to
f3a915d
Compare
filariow
approved these changes
Sep 3, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dependabot[bot], filariow The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
deleted the
dependabot/go_modules/operator/ginkgo-217d1f6e29
branch
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
This change wants to force the update of `e2e`'s indirect dependencies related to ginkgo and gomega when they are updated in `operator`. Look at #282 and #283 for examples of the problem. When gomega or ginkgo are updated in `operator`, they are not updated in `e2e` as they are indirect dependencies. As a consequence the build fails due to untidied gomod. Alternatively, we can add ginkgo and gomega as `e2e`'s direct dependencies. I think it would be good to start using gomega `e2e`, but I don't see space for ginkgo at the moment. Signed-off-by: Francesco Ilario <filario@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the ginkgo group with 1 update in the /operator directory: github.com/onsi/ginkgo/v2.
Bumps the ginkgo group with 1 update in the /server directory: github.com/onsi/ginkgo/v2.
Updates
github.com/onsi/ginkgo/v2from 2.20.1 to 2.20.2Release notes
Sourced from github.com/onsi/ginkgo/v2's releases.
Changelog
Sourced from github.com/onsi/ginkgo/v2's changelog.
Commits
104752fv2.20.2a671816bump go to v1.22Updates
github.com/onsi/ginkgo/v2from 2.20.1 to 2.20.2Release notes
Sourced from github.com/onsi/ginkgo/v2's releases.
Changelog
Sourced from github.com/onsi/ginkgo/v2's changelog.
Commits
104752fv2.20.2a671816bump go to v1.22Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions