This repository was archived by the owner on Nov 27, 2024. It is now read-only.
fix toolchain build/push scripts#78
Closed
filariow wants to merge 13 commits intokonflux-workspaces:mainfrom
Closed
fix toolchain build/push scripts#78filariow wants to merge 13 commits intokonflux-workspaces:mainfrom
filariow wants to merge 13 commits intokonflux-workspaces:mainfrom
Conversation
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
filariow
commented
Apr 18, 2024
Signed-off-by: Francesco Ilario <filario@redhat.com>
sadlerap
reviewed
Apr 18, 2024
Member
sadlerap
left a comment
sadlerap
left a comment
There was a problem hiding this comment.
largely lgtm, just a question
Member
|
@filariow Do we want to continue this PR in light of codeready-toolchain/toolchain-e2e#951? |
Member
|
@filariow I'm not sure this PR makes sense anymore, not after #94. If this is something you want to pursue further, I'd recommend splitting out the changes for building & pushing |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to the CI have been tested here