This repository was archived by the owner on Nov 27, 2024. It is now read-only.
ci: build & publish kubesaw components using FORCED_TAG#94
Merged
sadlerap merged 5 commits intokonflux-workspaces:mainfrom May 2, 2024
sadlerap:ci-build-push-images
Merged
ci: build & publish kubesaw components using FORCED_TAG#94sadlerap merged 5 commits intokonflux-workspaces:mainfrom sadlerap:ci-build-push-images
sadlerap merged 5 commits intokonflux-workspaces:mainfrom
sadlerap:ci-build-push-images
Conversation
Build and publish our kubesaw dependencies using the `publish-current-bundles-for-e2e` make target from toolchain-e2e. The containers built here will be deployed in openshift-ci during pull request testing. Signed-off-by: Andy Sadler <ansadler@redhat.com>
Signed-off-by: Andy Sadler <ansadler@redhat.com>
Signed-off-by: Andy Sadler <ansadler@redhat.com>
Member
Author
|
(this will fail to build until it's merged) |
Signed-off-by: Andy Sadler <ansadler@redhat.com>
Contributor
dperaza4dustbit
left a comment
dperaza4dustbit
left a comment
There was a problem hiding this comment.
Logic looks good, some comments on the current variable values
This is a more robust way of determining which branch we need to use
when we build kubesaw components. Branches are now resolved like so:
1. First check the repo-specific branch environment variable. If it's
set, use it.
2. If it's not set, use the generic `${BRANCH}` environment variable.
3. If `${BRANCH}` is not set, fall back to a default (in this case,
`master` for member-operator, `pubviewer-mvp` for all others).
Signed-off-by: Andy Sadler <ansadler@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build and publish our kubesaw dependencies using the
publish-current-bundles-for-e2emake target from toolchain-e2e. The containers built here will be deployed in openshift-ci during pull request testing.