Skip to content

chore: remove firebase-tools from workflow - #194

Merged
artembelik merged 1 commit into
mainfrom
chore/uninstall-firebase-tools-v2
Jul 17, 2026
Merged

chore: remove firebase-tools from workflow#194
artembelik merged 1 commit into
mainfrom
chore/uninstall-firebase-tools-v2

Conversation

@artembelik

@artembelik artembelik commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated deployment workflows to use Firebase Hosting deployment actions.
    • Added explicit repository read permissions for deployment runs.
    • Improved preview deployments by relying on configured service credentials instead of a hard-coded project identifier.
    • Continued supporting live and pull request–specific preview channels.

@artembelik artembelik self-assigned this Jul 17, 2026
Copilot AI review requested due to automatic review settings July 17, 2026 09:19
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 16dcc5df-beb3-4684-8c52-3b96cd1fd5e5

📥 Commits

Reviewing files that changed from the base of the PR and between 04d579e and 0871f13.

📒 Files selected for processing (2)
  • .github/workflows/deploy-next.yml
  • .github/workflows/redeploy-preview.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/redeploy-preview.yml

📝 Walkthrough

Walkthrough

GitHub Actions Firebase Hosting workflows now use explicit repository permissions and the Firebase Hosting deploy action for live deployments, while preview deployments no longer specify a hard-coded project ID.

Changes

Firebase Hosting workflows

Layer / File(s) Summary
Live hosting deployment configuration
.github/workflows/deploy-next.yml
Adds contents: read permissions and replaces the Firebase CLI deployment with FirebaseExtended/action-hosting-deploy@v0.11.0 targeting the live next channel.
Preview hosting deployment configuration
.github/workflows/redeploy-preview.yml
Removes the hard-coded projectId while retaining service-account, expiration, preview channel, and target inputs.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • koobiq/data-grid#191: Updates the preview Firebase Hosting workflow and overlaps on removal of the hard-coded project ID.
  • koobiq/data-grid#193: Updates Firebase Hosting workflows to use FirebaseExtended/action-hosting-deploy@v0.11.0.

Suggested reviewers: lskramarov, nikgurev, copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main workflow change: removing firebase-tools-based deployment from the GitHub Actions workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/uninstall-firebase-tools-v2

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 0871f13):

https://data-grid-next--data-grid-pr-194-zka5de1p.web.app

(expires Mon, 20 Jul 2026 09:21:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b9d49913f5b5988e9af8690a8b37f16143707448

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Firebase Hosting deployment workflows to avoid relying on the firebase-tools CLI in CI by switching to the FirebaseExtended/action-hosting-deploy action and adjusting related configuration.

Changes:

  • Replaces yarn firebase deploy ... in the deploy-next workflow with FirebaseExtended/action-hosting-deploy.
  • Adds explicit workflow permissions to deploy-next and removes an explicit projectId field from the redeploy-preview workflow inputs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/redeploy-preview.yml Removes the explicit projectId input from the hosting deploy step.
.github/workflows/deploy-next.yml Switches production/“next” deployment from Firebase CLI to FirebaseExtended/action-hosting-deploy and introduces explicit permissions.

Comment thread .github/workflows/deploy-next.yml
@artembelik
artembelik merged commit b20575c into main Jul 17, 2026
10 checks passed
@artembelik
artembelik deleted the chore/uninstall-firebase-tools-v2 branch July 17, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants