chore: remove firebase-tools from workflow - #194
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughGitHub Actions Firebase Hosting workflows now use explicit repository permissions and the Firebase Hosting deploy action for live deployments, while preview deployments no longer specify a hard-coded project ID. ChangesFirebase Hosting workflows
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Visit the preview URL for this PR (updated for commit 0871f13): https://data-grid-next--data-grid-pr-194-zka5de1p.web.app (expires Mon, 20 Jul 2026 09:21:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b9d49913f5b5988e9af8690a8b37f16143707448 |
There was a problem hiding this comment.
Pull request overview
This PR updates Firebase Hosting deployment workflows to avoid relying on the firebase-tools CLI in CI by switching to the FirebaseExtended/action-hosting-deploy action and adjusting related configuration.
Changes:
- Replaces
yarn firebase deploy ...in thedeploy-nextworkflow withFirebaseExtended/action-hosting-deploy. - Adds explicit workflow permissions to
deploy-nextand removes an explicitprojectIdfield from the redeploy-preview workflow inputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/redeploy-preview.yml | Removes the explicit projectId input from the hosting deploy step. |
| .github/workflows/deploy-next.yml | Switches production/“next” deployment from Firebase CLI to FirebaseExtended/action-hosting-deploy and introduces explicit permissions. |
Summary by CodeRabbit