fix(Table): rebuild collection when children change (DS-5260)#425
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit b03f9d5): https://react-koobiq-next--prs-425-nltai7gg.web.app (expires Tue, 21 Jul 2026 12:24:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: fc29847d4a9e5cb1adf458c76a9b681c76e2eeff |
There was a problem hiding this comment.
Pull request overview
This PR addresses a Table rendering bug by forcing the React Aria/Stately table collection to be rebuilt when children change, so dynamic row/column props (e.g., conditional className) are re-evaluated while preserving table state like selection, sorting, and column resizing.
Changes:
- Rebuild the Table collection on
childrenchanges and pass the resultingcollectionintouseTableState. - Re-export
CollectionBuilderfrom primitives asLegacyCollectionBuilderto support the collection rebuild logic. - Add regression tests to validate invalidation and preservation of selection/sorting/resizing across collection rebuilds.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/primitives/src/index.ts | Re-exports CollectionBuilder as LegacyCollectionBuilder for internal Table usage. |
| packages/components/src/components/Table/Table.tsx | Introduces a legacy-collection rebuild hook and injects collection into useTableState. |
| packages/components/src/components/Table/Table.test.tsx | Adds tests for dynamic row/column invalidation and state preservation across rebuilds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.