feat(components): add ButtonGroup component (DS-5244) - #436
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughChangesButtonGroup is introduced as a polymorphic, context-backed component. It provides grouped variant and disabled behavior, orientation styling, Storybook examples, documentation, tests, package exports, API extraction metadata, and roadmap registration. ButtonGroup component
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Consumer
participant ButtonGroup
participant ButtonGroupContext
participant Button
Consumer->>ButtonGroup: render grouped buttons
ButtonGroup->>ButtonGroupContext: provide variant and isDisabled
Button->>ButtonGroupContext: read group state
ButtonGroupContext-->>Button: inherited state
Button->>Button: compute effective variant and disabled state
Button-->>Consumer: render configured button
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visit the preview URL for this PR (updated for commit ed9eb4e): https://react-koobiq-next--prs-436-ub01wv3o.web.app (expires Sat, 08 Aug 2026 08:54:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: fc29847d4a9e5cb1adf458c76a9b681c76e2eeff |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/components/src/components/ButtonGroup/ButtonGroup.tsx`:
- Line 19: Update the destructured isDisabled prop in ButtonGroup to default to
false, preserving the component’s existing behavior while following the
boolean-prop convention.
In `@packages/components/src/components/ButtonGroup/index.ts`:
- Around line 1-3: Update the ButtonGroup entry-point barrel to re-export the
ButtonPropVariant type used by ButtonGroupBaseProps and ButtonGroupContextProps,
then regenerate the corresponding API Extractor report so the public API
includes the type without an ae-forgotten-export.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 86bd0a0c-2e10-4fa0-b129-3a03b4650e64
📒 Files selected for processing (16)
.storybook/components/Roadmap/data.tspackages/components/src/components/Button/Button.tsxpackages/components/src/components/Button/types.tspackages/components/src/components/ButtonGroup/ButtonGroup.mdxpackages/components/src/components/ButtonGroup/ButtonGroup.module.csspackages/components/src/components/ButtonGroup/ButtonGroup.stories.tsxpackages/components/src/components/ButtonGroup/ButtonGroup.test.tsxpackages/components/src/components/ButtonGroup/ButtonGroup.tsxpackages/components/src/components/ButtonGroup/ButtonGroupContext.tspackages/components/src/components/ButtonGroup/__stories__/styles.csspackages/components/src/components/ButtonGroup/index.tspackages/components/src/components/ButtonGroup/types.tspackages/components/src/components/index.tstools/api-extractor/config.jsontools/public_api_guard/components/Button.api.mdtools/public_api_guard/components/ButtonGroup.api.md
Summary by CodeRabbit
New Features
Bug Fixes
Tests