Skip to content

Feature/windows Version#43

Merged
fabriciojs merged 4 commits into
kool-dev:masterfrom
fbrissi:feature/windows_version
Sep 4, 2020
Merged

Feature/windows Version#43
fabriciojs merged 4 commits into
kool-dev:masterfrom
fbrissi:feature/windows_version

Conversation

@fbrissi

@fbrissi fbrissi commented Sep 2, 2020

Copy link
Copy Markdown
Contributor

#42

  • Added Inno Setup config to install for windows
  • When run in windows KOOL_ASUSER set 0

@dbpolito

dbpolito commented Sep 2, 2020

Copy link
Copy Markdown
Member

❤️ This is looking great.

@fabriciojs fabriciojs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I just left a few comments, and also would like to note that we should add some entry on the documentation markdown files about Windows support.

Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md Outdated
Comment thread enviroment/auser.go
Comment thread inno-setup/kool.iss Outdated
Comment thread install.bat Outdated
Comment thread build_artifacts.sh
@fbrissi

fbrissi commented Sep 3, 2020

Copy link
Copy Markdown
Contributor Author

Today I did many tests on a project with windows, It's ok for me.

WhatsApp Image 2020-09-03 at 20 31 14
WhatsApp Image 2020-09-03 at 20 30 50
WhatsApp Image 2020-09-03 at 20 29 35
WhatsApp Image 2020-09-03 at 20 28 59
WhatsApp Image 2020-09-03 at 20 28 38
WhatsApp Image 2020-09-03 at 20 27 59
WhatsApp Image 2020-09-03 at 20 27 21
image

@fabriciojs
fabriciojs merged commit c8e862f into kool-dev:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants