Skip to content

Tutorial for Unsharp Mask - #10

Merged
edgarriba merged 4 commits into
kornia:masterfrom
AnimeshMaheshwari22:Unsharp-mask-tutorial
May 25, 2021
Merged

Tutorial for Unsharp Mask#10
edgarriba merged 4 commits into
kornia:masterfrom
AnimeshMaheshwari22:Unsharp-mask-tutorial

Conversation

@AnimeshMaheshwari22

@AnimeshMaheshwari22 AnimeshMaheshwari22 commented May 17, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@review-notebook-app

review-notebook-app Bot commented May 17, 2021

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

edgarriba
edgarriba reviewed May 20, 2021
View reviewed changes
Comment thread source/Unsharp mask tutorial.ipynb
@@ -0,0 +1,206 @@
{

@edgarriba edgarriba May 20, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add %capture


Reply via ReviewNB

Comment thread source/Unsharp mask tutorial.ipynb
@@ -0,0 +1,206 @@
{

@edgarriba edgarriba May 20, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you choose an image with less resolution so that the blurring is more visible ?


Reply via ReviewNB

@edgarriba

edgarriba commented May 20, 2021

Copy link
Copy Markdown
Member

@AnimeshMaheshwari22 follow this tutorial for the style too https://github.com/kornia/tutorials/blob/master/source/gaussian_blur.ipynb

edgarriba
edgarriba approved these changes May 25, 2021
View reviewed changes

@edgarriba edgarriba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really cool !

@edgarriba

edgarriba commented May 25, 2021

Copy link
Copy Markdown
Member

@AnimeshMaheshwari22 please, added here : https://github.com/kornia/tutorials/blob/master/source/index.rst
oterhwise won't appear in the website.

@AnimeshMaheshwari22

AnimeshMaheshwari22 commented May 25, 2021

Copy link
Copy Markdown
Contributor Author

@AnimeshMaheshwari22 please, added here : https://github.com/kornia/tutorials/blob/master/source/index.rst
oterhwise won't appear in the website.

Added Unsharp mask tutorial to index.rst

@edgarriba
edgarriba merged commit ff614e4 into kornia:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edgarriba edgarriba edgarriba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AnimeshMaheshwari22 @edgarriba