Skip to content

Losing Lena - #11

Merged
edgarriba merged 1 commit into
kornia:masterfrom
diadochos:master
May 18, 2021
Merged

Losing Lena#11
edgarriba merged 1 commit into
kornia:masterfrom
diadochos:master

Conversation

@diadochos

Copy link
Copy Markdown
Contributor

This PR adds the "Gaussian Blur" tutorial from the original repository while solving the Losing Lena issue.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,235 @@
{

@edgarriba edgarriba May 18, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can download from here https://github.com/kornia/data/blob/main/bennett_aden.png so that we keep this repo light


Reply via ReviewNB

@diadochos

diadochos commented May 18, 2021

Copy link
Copy Markdown
Contributor Author

Hi @edgarriba, thanks for the review.

That sounds reasonable. I've updated the PR (with force-push, but just to avoid increasing the repo size due to the commit history of the data). The file has been tested on Colab, and it works fine with the new data URL.

Would you mind reviewing it again?

@edgarriba
edgarriba merged commit a590cad into kornia:master May 18, 2021
@edgarriba

Copy link
Copy Markdown
Member

That's amazing ! I'll remove from the the other place Lena ! We'll promote by the end of the end week this tutorial and movement/motivation for this. Can you share to me your linkedin and Twitter accounts to my personal mail ?

@diadochos

Copy link
Copy Markdown
Contributor Author

Sounds good! I'll send you my info :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants