test(docgen): swap deprecated-tag test's command name from report approval to report artifact

[ToreMerkely]

kosli report approval was removed in #1036, leaving the sample name
in TestMintlifyFrontMatterDeprecatedTag stale.

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com

[claude]

Claude finished @ToreMerkely's task in 53s —— View job

---

Review

Verdict: LGTM ✅ — a clean, correct docs-test hygiene fix.

• Gather context (read the changed test + diff)
• Static checks (go vet ./internal/docgen/ passes; package compiles)
• Review

What this does

internal/docgen/mintlify_test.go:49 swaps the sample command name in TestMintlifyFrontMatterDeprecatedTag from kosli report approval (removed in #1036) to kosli report artifact.

Assessment

• Correct. The test asserts only that Deprecated: true yields tag: "DEPRECATED". The Name value is just a sample fed into FrontMatter, so the swap is behaviorally inert — it removes a reference to a deleted command without changing what's tested. ✅
• New name is real. cmd/kosli/reportArtifact.go exists, so the sample no longer names a stale command. Confirmed the old approval command files are gone too. ✅
• Static analysis: go vet ./internal/docgen/ clean; package builds.
• Scope: minimal (+1/-1), no production code touched, no risk.

Minor note (non-blocking)

kosli report artifact isn't itself a deprecated command, so a reader could momentarily think the test implies it is. It doesn't — Deprecated: true is set explicitly on the struct — so this is purely cosmetic. If you wanted a sample that's self-documenting, an actually-deprecated command like kosli snapshot server (used in TestMintlifyDeprecatedWarning at line 109) would read a touch more naturally. Not worth blocking on.

Nice follow-up catch cleaning up the leftover from #1036.

[ToreMerkely]

Re the "minor note (non-blocking)": the premise here is incorrect — kosli report artifact is deprecated (cmd/kosli/reportArtifact.go:70, Deprecated: "see kosli attest commands"). So the sample already is a genuinely deprecated command; no change needed. Skipping.