Fix designated-initializer warnings on MTMathBoxDisplay and MTRuleDisplay#258
Merged
Conversation
…play Both classes declared `NS_DESIGNATED_INITIALIZER` on their init but never marked the inherited `-init` as unavailable, so clang warned "Method override for the designated initializer of the superclass '-init' not found". Every other MTDisplay subclass in this file already follows the `- (instancetype)init NS_UNAVAILABLE;` pattern.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request marks the default initializer init as unavailable (NS_UNAVAILABLE) for the MTMathBoxDisplay and MTRuleDisplay classes to prevent improper instantiation. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MTMathBoxDisplayandMTRuleDisplaydeclareNS_DESIGNATED_INITIALIZERon their init, but neither marks the inherited-initas unavailable. Clang warns: Method override for the designated initializer of the superclass '-init' not found.- (instancetype)init NS_UNAVAILABLE;to each interface — matches the pattern already used by every otherMTDisplaysubclass in the same file.Test plan
swift build— clean, no warnings.🤖 Generated with Claude Code