Skip to content

[AI] Issue #132: [FEATURE] Structured logs and pipeline health metrics - #133

Merged
koydas merged 5 commits into
mainfrom
ai/issue-132
May 6, 2026
Merged

[AI] Issue #132: [FEATURE] Structured logs and pipeline health metrics#133
koydas merged 5 commits into
mainfrom
ai/issue-132

Conversation

@koydas

@koydas koydas commented May 5, 2026

Copy link
Copy Markdown
Owner

AI Generated Change

Added log context and summary functionality to logger.mjs and updated auto_fix_pr.mjs to handle unhandledRejection and set log context

Closes #132

@koydas

koydas commented May 5, 2026

Copy link
Copy Markdown
Owner Author

🔍 Automated Code Review

✅ Summary

Added structured logging API with context propagation, step timing, and run summaries. Updated auto-fix script to use new logging functions and handle unhandled rejections. Expanded test coverage for all changes.

⚠️ Issues Found

  • HIGH Minimum test coverage policy missing for new logging API - docs/code-generation.md Lines: 97-149 Root cause: New structured logging functionality lacks explicit minimum test coverage requirement despite adding critical automation infrastructure. Fix: Add coverage policy for logger.mjs similar to existing config validation policy.

🚀 Verdict

REQUEST_CHANGES

Automation gates verification:

  • ✅ Unit tests present for new functionality
  • ✅ Documentation updated with API reference
  • ❌ No minimum coverage policy specified for new code (structured logging implementation)

@koydas koydas added changes-requested Automated code review found issues requiring changes and removed changes-requested Automated code review found issues requiring changes labels May 5, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15e89a0fff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/auto_fix_pr.mjs
Comment on lines 211 to 212
const systemTokens = estimateTokens(systemPrompt);
const contextWindow = MODEL_CONTEXT_WINDOW[model] ?? (llmProvider === 'groq' ? 32768 : 200000);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Restore auto-fix execution after token budgeting

The script now terminates right after computing contextWindow, because the entire execution path that builds prompts, calls the LLM, writes generated files, applies attempt labels, and emits outputs was removed. In this state, auto-fix runs become a silent no-op for all PRs that pass earlier guards, so the workflow no longer performs its core function even though it logs startup successfully.

Useful? React with 👍 / 👎.

The PR accidentally deleted the entire core logic after contextWindow
computation: token budgeting, diff fetch, LLM call, file writing, and
label creation. This restores those 125 lines and adds back the shebang.

https://claude.ai/code/session_01ABR3pxJPt1tdUzFLWqmgMq
@koydas koydas added changes-requested Automated code review found issues requiring changes and removed changes-requested Automated code review found issues requiring changes labels May 5, 2026
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

🤖 Auto-Fix Skipped

This PR modifies scripts/auto_fix_pr.mjs. Automated self-modification is disabled to prevent feedback loops. Please review and merge this PR manually.

claude added 2 commits May 5, 2026 17:00
…gEnd

Adds 6 unit tests for the new structured logging functions and 1 integration
test verifying the unhandledRejection handler emits run_summary with
success: false. Also documents the logging API in code-generation.md.

https://claude.ai/code/session_01ABR3pxJPt1tdUzFLWqmgMq
@koydas koydas added changes-requested Automated code review found issues requiring changes and removed changes-requested Automated code review found issues requiring changes labels May 6, 2026
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

🤖 Auto-Fix Skipped

This PR modifies scripts/auto_fix_pr.mjs. Automated self-modification is disabled to prevent feedback loops. Please review and merge this PR manually.

Replaces implicit global crypto.randomUUID() with an explicit named import,
compatible with all Node.js ESM environments.

https://claude.ai/code/session_01ABR3pxJPt1tdUzFLWqmgMq
@koydas koydas added changes-requested Automated code review found issues requiring changes and removed changes-requested Automated code review found issues requiring changes labels May 6, 2026
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

🤖 Auto-Fix Skipped

This PR modifies scripts/auto_fix_pr.mjs. Automated self-modification is disabled to prevent feedback loops. Please review and merge this PR manually.

@koydas
koydas merged commit 11d4d2c into main May 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes-requested Automated code review found issues requiring changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Structured logs and pipeline health metrics

2 participants