Refactor update logic in pkg/lib/kptops (cleanup + structure improvements) (#4379)

[NETIZEN-11]

PR Description: Stabilize ResourceGroup API to v1

## Summary

This PR introduces the stable v1 API for the ResourceGroup type while maintaining full backwar
d compatibility with the existing v1alpha1 API.

## Motivation

The ResourceGroup API has been in v1alpha1 for significant time. This PR stabilizes it to v1,
 indicating API maturity and signaling that users can rely on this API with confidence. Followi
 ng semantic versioning, the v1 API will not introduce breaking changes except in a future v2.0
  release.

Changes

New Files

• pkg/api/resourcegroup/v1/doc.go - Package documentation with stability guarantees
• pkg/api/resourcegroup/v1/types.go - Stable v1 ResourceGroup type definition

Modified Files

• pkg/api/resourcegroup/v1alpha1/types.go - Added deprecation notices pointing users to v1

Key Changes

1. Stable v1 API (pkg/api/resourcegroup/v1/):

   • ResourceGroupGVK() - Returns stable GroupVersionKind for v1
   • RGFileName, RGInventoryIDLabel, RGFileKind, RGFileGroup, RGFileVersion, RGFile APIVersion constants
   • DefaultMeta - Default ResourceMeta for ResourceGroup instances
   • ResourceGroup struct - The stable inventory type for packages managed with kpt

2. v1alpha1 Deprecation:

   • Added deprecation notices to all v1alpha1 constants and functions
   • ResourceGroupGVK() in v1alpha1 now returns v1alpha1 GVK but is marked deprecated
     - Users are directed to use github.com/kptdev/kpt/pkg/api/resourcegroup/v1 instead

3. Backward Compatibility:

   • v1alpha1 API is fully preserved
   • Existing code using v1alpha1 will continue to work
   • Migration path: users can migrate to v1 at their convenience

API Stability

The v1 API follows semantic versioning:

• Breaking changes will NOT be introduced in v1.x releases
• Such changes, if needed, will only come in v2.0.0
• Bug fixes and improvements will be backward-compatible

Testing

• Build passes: go build ./pkg/api/resourcegroup/...
• Vet passes: go vet ./pkg/api/resourcegroup/...
• All existing tests pass

Related Issue

Part of #4450 - API Types Stabilization

Future Work

• Update all internal usages of ResourceGroup to use v1
• Eventually deprecate and remove v1alpha1 in v2.0

---

[NETIZEN-11]

Hi @CsatariGergely,

Thanks for the review.

I’ve fixed the CI errors and resolved the DCO issue. All checks are now passing.

Could you please take another look when you have time?

Thanks!

[Copilot]

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (2)

internal/util/render/executor.go:950

• Malformed if statement. Line 943 opens an if block if function.ConfigPath != "" but is immediately followed by unindented code on line 944 that should be inside the block. The indentation and structure is broken. This appears to be a merge conflict or incomplete refactoring.

	for i, mutator := range mutators {
		function := pl.Mutators[i]
		stepResult := createPipelineStepResult(function, 0, "", "")

		if function.ConfigPath != "" {
		resultCountBeforeExec := len(hctx.fnResults.Items)

		if pl.Mutators[i].ConfigPath != "" {
			// functionConfigs are included in the function inputs during `render`
			// and as a result, they can be mutated during the `render`.
			// So functionConfigs needs be updated in the FunctionRunner instance
			// before every run.

internal/util/render/executor_test.go:610

• Duplicate field initializations in hydrationContext struct literal. The fields root, pkgs, and fileSystem are initialized twice (lines 603-605 and 607-609). This will cause a compilation error as duplicate struct field initializers are not allowed.

	hctx := &hydrationContext{
		root:         &pkgNode{pkg: rootPkg},
		pkgs:         map[types.UniquePath]*pkgNode{},
		fileSystem:   mockFS,
		renderStatus: &kptfilev1.RenderStatus{},
		root:       &pkgNode{pkg: rootPkg},
		pkgs:       map[types.UniquePath]*pkgNode{},
		fileSystem: mockFS,
	}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 29 out of 30 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 29 out of 30 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

pkg/api/kptfile/v1/types.go:449

• Duplicate field definition in ResultItem struct. Line 443 defines Resource field but there's evidence from the diff context showing this was added as a new field. However, the struct appears to already have all the necessary fields. Need to verify if Resource field duplication exists in the added code.

type ResultItem struct {
	Resource    string `yaml:"resource,omitempty" json:"resource,omitempty"`
	Message     string `yaml:"message,omitempty" json:"message,omitempty"`
	Severity    string `yaml:"severity,omitempty" json:"severity,omitempty"`
	ResourceRef *ResourceRef `yaml:"resourceRef,omitempty" json:"resourceRef,omitempty"`
	Field       *FieldRef    `yaml:"field,omitempty" json:"field,omitempty"`
	File        *FileRef     `yaml:"file,omitempty" json:"file,omitempty"`
}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[liamfallon]

This PR is very large. Please provide a comprehensive description of the changes made. It wold be useful if you were free to present your PR to the community at an upcoming community meeting. The meetings are on Wednesdays, see the calendar appointment here: https://www.cncf.io/calendar/ and search for 'kpt'

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.