Docs: Fix broken download links#4624
Merged
Merged
Conversation
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes broken kpt CLI download links in the documentation site build by ensuring the version is derived only from top-level CLI release tags (e.g. v1.0.0-*), avoiding Go module sub-path tags like api/v0.0.2.
Changes:
- Update
git describeinvocations in the documentation Makefile to include--match='v[0-9]*'when computingHUGO_KPT_VERSION. - Apply the same tag-filtering behavior to both
production-buildandpreview-buildtargets.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aravindtga
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
dosubot
Bot
added
size:XS
aravindtga
changed the title
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
aravindtga
force-pushed
the
documentation-version-tag-match
branch
from
b652b87 to
4009ceb
Compare
liamfallon
approved these changes
Jul 8, 2026
efiacor
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
--match='v[0-9]*'togit describein the documentation Makefile to ensure only CLI release tags are used when resolving the kpt version for download links.Motivation
The recent release of
api/v0.0.2causedgit describe --tags --abbrev=0to returnapi/v0.0.2instead of the latest CLI release tag (e.g.v1.0.0-beta.65.1). The--match='v[0-9]*'filter excludes Go module sub-path tags (api/*,porch/*, etc.) which follow standard Go module versioning conventions andwill never be CLI release tags.
Fixes #4623
AI Usage Disclosure