Skip to content

Linking container images to releases and remove gcloud image build#4628

Merged
liamfallon merged 3 commits into
kptdev:mainfrom
nokia:link-containers-to-releases
Jul 8, 2026
Merged

Linking container images to releases and remove gcloud image build#4628
liamfallon merged 3 commits into
kptdev:mainfrom
nokia:link-containers-to-releases

Conversation

@CsatariGergely

@CsatariGergely CsatariGergely commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

GitHub links the images in ghcr based on the org.opencontainers.image.source and org.opencontainers.image.version image annotations. This pr adds these annotations (and some more) to the image building.

We do not need a gcloud specific container build anymore, so the related build config was removed.

Fixes #4627

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Copilot AI review requested due to automatic review settings July 8, 2026 13:13
@CsatariGergely CsatariGergely requested a review from efiacor as a code owner July 8, 2026 13:13
@netlify

netlify Bot commented Jul 8, 2026

Copy link
Copy Markdown

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit 6344703
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/6a4e59fd8c1c480008944e5f
😎 Deploy Preview https://deploy-preview-4628--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. area/release kpt release issues go Pull requests that update Go code labels Jul 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release container build to publish OCI image annotations needed for GitHub to link GHCR images to GitHub Releases, and removes the legacy kpt-gcloud image build path.

Changes:

  • Add OCI org.opencontainers.image.* labels to the GoReleaser Docker build.
  • Remove the ghcr.io/kptdev/kpt-gcloud image build from the GoReleaser config.
  • Delete the no-longer-needed release/images/Dockerfile-gcloud.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
release/tag/goreleaser.yaml Adds OCI labels to the GHCR image build and removes the gcloud image build entry.
release/images/Dockerfile-gcloud Removes the obsolete Dockerfile used for the gcloud-specific image.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread release/tag/goreleaser.yaml Outdated
Comment thread release/tag/goreleaser.yaml Outdated
Comment thread release/tag/goreleaser.yaml Outdated
Comment thread release/tag/goreleaser.yaml
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 8, 2026
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Assisted-by: GitHub Copilot: Claude Haiku 4.5
@dosubot dosubot Bot added the lgtm label Jul 8, 2026
@liamfallon liamfallon merged commit c5b53cc into kptdev:main Jul 8, 2026
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/release kpt release issues go Pull requests that update Go code lgtm size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link container images to the releases and remove gcloud build

5 participants