Unset line width to allow arbitrarily long lines #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prachirp is there any way to unit test this ? |
frankfarzan
reviewed
Jun 25, 2020
ts/kpt-functions/src/io.ts
Outdated
| // only skip 'undefined'. | ||
| skipInvalid: true, | ||
| // increase lineWidth from default of 80 to avoid reformatting | ||
| lineWidth: 120, |
There was a problem hiding this comment.
is this what kpt CLI uses? Any follow up for other styling consistency between the two?
There was a problem hiding this comment.
@phanimarupaka checked kpt and found that it doesn't have any line width limit so we agreed on 120.
I found another inconsistency where kpt keeps single quotes while sdk removes them but there is no clear way to tell DumpOptions to do this.
prachirp
changed the title
frankfarzan
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @phanimarupaka @frankfarzan
Increase line width to 120 as a workaround for kptdev/kpt#685