Skip to content

Unset line width to allow arbitrarily long lines #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2020
Merged

Unset line width to allow arbitrarily long lines #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
341722c
Increase line width to avoid reformatting yaml
prachirp Jun 25, 2020
4f1caf7
Add tests
prachirp Jun 25, 2020
b5abcce
Set unlimited lineWidth
prachirp Jun 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ts/kpt-functions/src/io.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ const YAML_STYLE: DumpOptions = {
// Either reason about not having 'undefined' in all cases OR
// only skip 'undefined'.
skipInvalid: true,
// unset lineWidth from default of 80 to avoid reformatting
lineWidth: -1,
};

/**
Expand Down
29 changes: 29 additions & 0 deletions ts/kpt-functions/src/io_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,35 @@ results:
severity: error
`);
});

it('preserves long lines', () => {
const result = stringify(
new Configs([
{
apiVersion: 'v1',
kind: 'Namespace',
metadata: {
name:
'0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789',
},
},
]),
FileFormat.YAML
);

expect(result).toEqual(
`apiVersion: v1
kind: ResourceList
metadata:
name: output
items:
- apiVersion: v1
kind: Namespace
metadata:
name: 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
`
);
});
});

describe('in JSON format', () => {
Expand Down