Conversation
The API status page hot-linked the Polleninformation logo from polleninformation.at, whose asset path includes a cache-busting hash that changed on a site redeploy, breaking the image. Vendor the logo under docs/ and reference it relatively so the page no longer depends on their site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The API status page (https://krissen.github.io/polleninformation/) hot-linked the Polleninformation logo directly from polleninformation.at. Their asset path contains a cache-busting hash that changed on a site redeploy, so the old URL now returns 404 and the logo renders as broken alt text.
Fix
docs/logo_polleninformation.svg(uploaded with the rest ofdocs/as the Pages artifact).scripts/check_api_status.py, removing the dependency on their site.Changelog
v0.5.2 (unreleased)section documenting this fix.