Skip to content

merge Code dump into main - #11

Merged
ImMihai689 merged 4 commits into
mainfrom
Code-Dump
Aug 7, 2026
Merged

merge Code dump into main#11
ImMihai689 merged 4 commits into
mainfrom
Code-Dump

Conversation

@ImMihai689

@ImMihai689 ImMihai689 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Robot heading can now be initialized with a specified starting orientation.
    • Final robot poses are saved when autonomous replay or manual driving ends.
    • Manual controls now support differential trigger-based loader and intake operation.
  • Improvements
    • Auto-aim and shooting range selection now work together more predictably.
    • Limelight turret corrections adapt based on targeting error, improving aiming responsiveness.

@ImMihai689
ImMihai689 merged commit b7f1622 into main Aug 7, 2026
@ImMihai689
ImMihai689 deleted the Code-Dump branch August 7, 2026 12:12
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c14f5a53-065d-4174-85d5-97079b17edce

📥 Commits

Reviewing files that changed from the base of the PR and between ac8df77 and 6d22e62.

📒 Files selected for processing (5)
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/autonomous/FinalReplayOp.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/FinalRecorderOp.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.java
  • TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.java

📝 Walkthrough

Walkthrough

The changes update robot heading initialization, Limelight turret correction behavior, manual intake and shooting controls, and final follower-pose persistence in manual and replay op modes.

Changes

Robot operation updates

Layer / File(s) Summary
Heading initialization and Limelight aiming
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/Robot.java, TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/utils/Constants.java
Heading initializes from an optional heading. Limelight orientation and odometry aiming use the follower pose heading. Turret corrections use separate limits for errors above and below 10 degrees.
Manual intake and shooting controls
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/FinalRecorderOp.java
Loader control uses the difference between the triggers. Discrete shooting ranges run only when auto-aim is disabled.
Final pose persistence
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/manual/MainDrivingOp.java, TeamCode/src/main/java/org/firstinspires/ftc/teamcode/kronbot/autonomous/FinalReplayOp.java
Both op modes save the follower’s final pose during shutdown.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • kronbot/decode#2: Related heading and follower initialization changes in Robot.java.
  • kronbot/decode#3: Related Robot.java, op mode, constants, pose persistence, and auto-aim changes.
  • kronbot/decode#9: Related Limelight turret aiming and correction-limit changes.

Suggested reviewers: robi2903, chiriacioana

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch Code-Dump

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants