[codex] Replace wiptype with bamltype and vendor facet - #60
Merged
Conversation
darinkishore
force-pushed
the
codex/facet-bamltype-parity
branch
6 times, most recently
from
February 7, 2026 21:28
344cb00 to
86fea56
Compare
darinkishore
force-pushed
the
codex/facet-bamltype-parity
branch
from
February 7, 2026 21:30
86fea56 to
e9073fa
Compare
darinkishore
marked this pull request as ready for review
February 7, 2026 21:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the in-progress typed schema integration from the temporary
wiptypepath to a first-classbamltype/bamltype-deriveimplementation, vendors the Facet crates required for reflection, and wires the DSRs runtime + macros to the new typed contracts.User impact
Typed prompt/schema generation and parsing now run through the new
bamltypebridge and Facet-backed conversion path, with parity tests and UI diagnostics in place. This improves correctness and keeps macro/runtime contracts aligned for downstream users.Root cause
The prior implementation lived in a temporary
wiptypetrack and relied on intermediate compatibility behavior while schema/rendering/parsing semantics were still shifting. That left the integration split across temporary crates and ad-hoc fixes.What changed
crates/bamltype,crates/bamltype-derive.crates/dspy-rsandcrates/dsrs-macrosto consume the new typed bridge and attributes.vendor/facet*and integrated them as path dependencies.*.profraw) and workspace dirs.Validation
cargo test -p dspy-rs --testscargo test -p bamltype --testscargo test -p dsrs_macros --testsNotes
.profrawfiles were removed from the PR scope.