Skip to content

Refactor: add resuable delete server popup with delete service option and comment out plans route - #439

Merged
nitin-iqudtek merged 2 commits into
mainfrom
refactor/dp/delete-popup
Aug 4, 2026
Merged

Refactor: add resuable delete server popup with delete service option and comment out plans route#439
nitin-iqudtek merged 2 commits into
mainfrom
refactor/dp/delete-popup

Conversation

@dhaval-p-iqud

@dhaval-p-iqud dhaval-p-iqud commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

📝 What does this change do?

  • Reused the delete server popup component in the Server Details → Settings tab.
  • Reused the component across other applicable server deletion flows.
  • Added support for the Delete Service option where required.
  • Comment out plans and invoice routes temporary

🔗 Related Issue / Task

🧪 How was this tested?

  • [✅] Manually tested

Steps to Test:

  1. Navigate to the Server Details page.
  2. Open the Settings tab and click the Delete button.
  3. Verify the reusable delete popup is displayed and the delete flow works correctly.
  4. Verify other server deletion flows use the same popup.

⚠️ Impact / Risks

  • Any breaking changes? NA
  • Any performance impact? NA
  • Any migration required? NA

✅ Checklist

  • [✅] Code is self-reviewed
  • [✅] Follows project conventions
  • [✅] No unnecessary logs / debug code

@dhaval-p-iqud
Refactor: added resuable delete server popup with delete service option
4f71535 
- Reused component in server details page setting tab delet button popup
- Reused component where needed to delete server
@dhaval-p-iqud dhaval-p-iqud self-assigned this Aug 4, 2026
@dhaval-p-iqud dhaval-p-iqud added the enhancement New feature or request label Aug 4, 2026
@dhaval-p-iqud
Refactor: comment out unused routes and menu items for plans and invo…
b9288cd 
…ices

- Commented out the PlansPage and InvoicesPage routes in the router.
- Updated ProfileMenu to comment out related active state checks and links.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Deploying console with  Cloudflare Pages  Cloudflare Pages

Latest commit: b9288cd
Status: ✅  Deploy successful!
Preview URL: https://29f1e105.core-6vy.pages.dev
Branch Preview URL: https://refactor-dp-delete-popup.core-6vy.pages.dev

View logs

@dhaval-p-iqud dhaval-p-iqud changed the title Refactor: add resuable delete server popup with delete service option Refactor: add resuable delete server popup with delete service option and comment out plans route Aug 4, 2026
@nitin-iqudtek
nitin-iqudtek added this pull request to the merge queue Aug 4, 2026
Merged via the queue into main with commit a2527f3 Aug 4, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitin-iqudtek nitin-iqudtek nitin-iqudtek approved these changes

Assignees

@dhaval-p-iqud dhaval-p-iqud

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor: Reusable Delete Server Popup

2 participants

@dhaval-p-iqud @nitin-iqudtek