ISSUE-648: Change status and metadata classes to functional components#722
Conversation
jesuino
left a comment
There was a problem hiding this comment.
Hello Adam,
Thanks for your work on this, I checked the other PR and it is looking good! Would it be possible to do all work in a single PR? It will even better for your to work on a single PR because when you get to dependent components you may have weird behavior related to state mismatch.
Thanks!
| // limitations under the License. | ||
|
|
||
| import * as React from 'react'; | ||
| // import { CSSProperties } from 'jss/css'; |
There was a problem hiding this comment.
Can we take this opportunity to remove unused comments?
670b8e4 to
055f7f1
Compare
jesuino
left a comment
There was a problem hiding this comment.
Hello Adam,
Thanks again for your work on this. It is looking great and Kale is working as expected, but I noticed that the recently added output_path setting is not on your branch. Was it lost during some merge with main?
Thanks!
Split CellMetadataEditor into smaller functional components, extract dialogs and hooks, convert status icons to functions, and fix page scrolling when editing cell metadata. Signed-off-by: Adam Maly <amaly@redhat.com>
…ges for some reason I cant remember Signed-off-by: Adam Maly <amaly@redhat.com>
Signed-off-by: Adam Maly <amaly@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#648
This PR refactors these classes into functional components:
For better code quality and readability there were some new hooks and separate component files added:
New hooks:
New dialog components (extracted from CellMetadataEditor):
Other cleanup:
Left Panel will be refactored in another PR.
also this PR fixes: #770
TESTING:
To test this I spinned up jupyter lab with these changes and jupyter lab from main and I compared the behaviour of UI. I recommend for testing of this PR to do the same thing.