-
Notifications
You must be signed in to change notification settings - Fork 228
Expose main container name as a configurable field #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose main container name as a configurable field #174
Conversation
terrytangyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ywskycn Could you fix this? |
|
@terrytangyuan , may need to change this PR. In the One approach would be, we read the worker's container name on-the-fly for each job, ant put the name in the kubectl script. But this is still have risk if users specify more than one container in the worker spec, in which we don't which is the main container, which is the sidecar... |
|
New changes are detected. LGTM label has been removed. |
|
Add a new PR which exposes the If users don't specify |
terrytangyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Expose
main container nameas a configurable field. This is used for cases where launcher/worker pods have sidecars. Existingkubectl execcommand inmpi_job_controller.godoesn't include container name, causing the command fails.This change is