Skip to content

Conversation

@ywskycn
Copy link
Member

@ywskycn ywskycn commented Jan 21, 2020

The worker command was hardcoded as sleep 365d, no matter what command users specify. This PR is to honor users' inputs.


This change is Reviewable

@ywskycn
Copy link
Member Author

ywskycn commented Jan 22, 2020

Rethinking this patch's approach. Another way would be reusing spec.mpiReplicaSpecs.Worker.template.spec.containers[0].command|args.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, especially now that v1alpha2 is more flexible, we can just reuse the worker template spec.

@ywskycn ywskycn changed the title Allow users customize worker command Honor user-typed worker command Jan 22, 2020
@ywskycn
Copy link
Member Author

ywskycn commented Jan 22, 2020

Yes, especially now that v1alpha2 is more flexible, we can just reuse the worker template spec.

Update the PR which directly checks if users place a customized worker command in the spec.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 715e13c into kubeflow:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants