chore: add issue templates and contributing guide by ederign · Pull Request #4 · kubeflow/notebooks

ederign · 2024-05-09T12:55:49Z

To see this running:

Issues:
https://github.com/ederign/notebooks/issues/new/choose

PR:

Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>

ederign · 2024-05-09T12:56:52Z

@thesuperzapper ^

Co-authored-by: Jiri Daněk <jdanek@redhat.com>

ederign · 2024-05-29T12:06:20Z

@jiridanek @thesuperzapper, do you think we can merge this as a starting point?

jiridanek · 2024-05-29T12:13:00Z

+      value: |
+        # Bug Report
+
+        Thanks for helping make the Kubeflow Notebooks project better!


Suggested change

Thanks for helping make the Kubeflow Notebooks project better!

Thanks for helping to make the Kubeflow Notebooks project better!

jiridanek · 2024-05-29T12:15:14Z

+
+The contributor's guide
+
+* shows you where to find the Contributor License Agreement (CLA) that you need 


Suggested change

* shows you where to find the Contributor License Agreement (CLA) that you need

We have https://developercertificate.org/, not cla. Cla is evil.

@ederign btw, don't forget to sign commits ;P

Co-authored-by: Jiri Daněk <jdanek@redhat.com> Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>

Co-authored-by: Jiri Daněk <jdanek@redhat.com>

google-oss-prow · 2024-05-30T17:03:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiridanek
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jiridanek · 2024-05-30T17:04:03Z

+feat(ws): my commit message`
+
+Signed-off-by: John Smith <john-smith@users.noreply.github.com>
+```


no new line at the end of file

…tep1 fix(ws): UI fixes for Step 1 of Workspace Creation

# This is the 1st commit message: feat: implement podtemplate details endpoint for workspace overlay Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com> chore: update ts-jest to 29.4.9 (kubeflow#1096) Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com> fix: add namespace to storageclasses api and check pvc create for auth (kubeflow#1097) * fix: add namespace parameter to storageclasses endpoint Regular Kubeflow users get 403 on /storageclasses because the backend issues a cluster-wide SAR (namespace="") that requires a ClusterRoleBinding, but users only have a namespace-scoped RoleBinding. - Add namespace query param to GET /storageclasses: when provided the SAR is scoped to that namespace (matching the existing workspacekinds pattern), allowing regular users through; without it the endpoint remains admin-only - Add nolint:dupl to GetStorageClassesHandler and GetWorkspaceKindsHandler Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Christian Heusel <christian@heusel.eu> * chore: disable duplication linter for handler files Add a targeted golangci.yml exclude rule for api/*_handler.go files instead of per-function //nolint:dupl comments, and remove all stale directives from pvcs, secrets, workspaces, workspacekinds, and storageclasses handlers. Link: kubeflow#1097 (comment) Signed-off-by: Christian Heusel <christian@heusel.eu> --------- Signed-off-by: Christian Heusel <christian@heusel.eu> # This is the commit message kubeflow#2: chore: note reason for the role aggregation structure (kubeflow#1100) This has caused multiple people confusion by now which means that we should most likely note it in the code itself. Additionally this way we guard ourselves against reverting / "simplifying" this on accident in the future. Signed-off-by: Christian Heusel <christian@heusel.eu> Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> # This is the commit message kubeflow#3: chore: Bump the mod-arch-packages group across 1 directory with 3 updates (kubeflow#1084) Bumps the mod-arch-packages group with 3 updates in the /workspaces/frontend directory: [mod-arch-core](https://github.com/opendatahub-io/mod-arch-library/tree/HEAD/mod-arch-core), [mod-arch-kubeflow](https://github.com/opendatahub-io/mod-arch-library/tree/HEAD/mod-arch-kubeflow) and [mod-arch-shared](https://github.com/opendatahub-io/mod-arch-library/tree/HEAD/mod-arch-shared). Updates `mod-arch-core` from 1.15.4 to 1.16.1 - [Release notes](https://github.com/opendatahub-io/mod-arch-library/releases) - [Commits](https://github.com/opendatahub-io/mod-arch-library/commits/1.16.1/mod-arch-core) Updates `mod-arch-kubeflow` from 1.15.4 to 1.16.1 - [Release notes](https://github.com/opendatahub-io/mod-arch-library/releases) - [Commits](https://github.com/opendatahub-io/mod-arch-library/commits/1.16.1/mod-arch-kubeflow) Updates `mod-arch-shared` from 1.15.4 to 1.16.1 - [Release notes](https://github.com/opendatahub-io/mod-arch-library/releases) - [Commits](https://github.com/opendatahub-io/mod-arch-library/commits/1.16.1/mod-arch-shared) --- updated-dependencies: - dependency-name: mod-arch-core dependency-version: 1.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: mod-arch-packages - dependency-name: mod-arch-kubeflow dependency-version: 1.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: mod-arch-packages - dependency-name: mod-arch-shared dependency-version: 1.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: mod-arch-packages ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> # This is the commit message kubeflow#4: feat: enable WorkspaceKind update in FrontEnd (kubeflow#1093) * feat: Enable WorkspaceKind Update Signed-off-by: Charles Thao <cthao@redhat.com> * Only enable Save when changes are made Signed-off-by: Charles Thao <cthao@redhat.com> * add tests Signed-off-by: Charles Thao <cthao@redhat.com> --------- Signed-off-by: Charles Thao <cthao@redhat.com> # This is the commit message kubeflow#5: feat: use listValues to render Image and Pod Config steps in Workspac… (kubeflow#1098) * feat: use listValues to render Image and Pod Config steps in Workspace Form Signed-off-by: Charles Thao <cthao@redhat.com> * fix: make error message display more explicit Signed-off-by: Charles Thao <cthao@redhat.com> --------- Signed-off-by: Charles Thao <cthao@redhat.com> # This is the commit message kubeflow#6: fix: pass namespace to list workspacekinds on workspace edit (kubeflow#1106) * fix(frontend): use useWorkspaceKinds in useWorkspaceFormData to fix 403 on edit When editing a Workspace via the UI, non-admin users received a 403 error. The root cause was that useWorkspaceFormData called listWorkspaceKinds({}) directly — without the namespaceFilter query parameter. Without namespaceFilter, the backend checks for cluster-level "list WorkspaceKinds" permission instead of the namespace-scoped "create Workspaces" permission that regular users have. The create flow worked because WorkspaceFormKindSelection fetches kinds through useWorkspaceKinds(namespace), which always includes namespaceFilter. The edit flow bypassed that code path entirely. Rather than just adding namespaceFilter to the raw API call, this fix replaces the direct listWorkspaceKinds({}) call with the shared useWorkspaceKinds(namespace) hook. Both the edit flow (useWorkspaceFormData) and the create flow (WorkspaceFormKindSelection) now go through the same code path, so they cannot diverge on authorization behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Andy Stoneberg <astonebe@redhat.com> * chore: address PR feedback Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Andy Stoneberg <astonebe@redhat.com> --------- Signed-off-by: Andy Stoneberg <astonebe@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> # This is the commit message kubeflow#7: fix: pass namespace query param when listing storage classes (kubeflow#1107) PR kubeflow#1097 added a `namespace` query parameter to the backend's GET /storageclasses endpoint. When provided, the backend checks namespace-scoped "create PersistentVolumeClaims" permission instead of cluster-level "list StorageClasses" — allowing regular (non-admin) users to access storage classes within their namespace. The frontend's useStorageClasses hook was calling listStorageClasses() without the namespace parameter, causing non-admin users to receive a 403 when opening the volume creation or attachment modals in the Workspace Wizard (both Create and Edit flows). This fix mirrors the approach taken in PR kubeflow#1106 for workspace kinds: the useStorageClasses hook now accepts an optional namespace argument and passes it as a query parameter to the API. Both VolumesCreateModal and VolumesAttachModal pass selectedNamespace from the namespace selector context. swagger.version is updated from c9a8a7c to 142a30f (the PR kubeflow#1097 commit) so that the generated API client includes the new namespace query parameter on listStorageClasses. Signed-off-by: Andy Stoneberg <astonebe@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> # This is the commit message kubeflow#8: ci: automatically approve tests for org members (kubeflow#1111) The idea behind this is that they could set the 'ok-to-test' label anyways via prow and it eases the burden of the maintainers having to do this manually for org members. The code is taken from the way that `kubeflow/sdk` does it for their equivalent job. Link: https://github.com/kubeflow/sdk/blob/main/.github/workflows/gh-workflow-approve.yaml Signed-off-by: Christian Heusel <christian@heusel.eu> # This is the commit message kubeflow#9: chore: upgrade setup-go to 6.4.0 (kubeflow#1116) * chore: Bump actions/setup-go from 5.6.0 to 6.4.0 Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.6.0 to 6.4.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@40f1582...4a36011) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 6.4.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * fix: set GOTOOLCHAIN=local+auto in Makefiles for setup-go compatibility The setup-go GitHub Action sets GOTOOLCHAIN=local, which prevents go-install-tool from downloading tools that require a newer Go version. Override with local+auto in both backend and controller Makefiles. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Andy Stoneberg <astonebe@redhat.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Andy Stoneberg <astonebe@redhat.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> # This is the commit message kubeflow#10: ci: scaffold e2e testing framework infrastructure (kubeflow#763) * ci: scaffold e2e testing framework infrastructure This commit establishes the foundational infrastructure for end-to-end testing of the workspaces components. While some of the scripts appear redundant with the developing/ directory, a deliberate decision was made to keep this logic mutually exclusive to be more flexible. For instance, the testing/ directory has a need to deploy a Gateway that is not necessary for developing. Keeping everything separate for now makes it easier to evolve independently. Changes include: - Add new `testing/` directory with Makefile and setup scripts: * `setup-kind.sh`: Automated Kind cluster creation and configuration * `setup-cert-manager.sh`: Cert-manager installation (v1.12.13 LTS) * `setup-istio.sh`: Istio service mesh installation with Gateway and TLS certificate provisioning via cert-manager * `check-kind-context.sh`: Safety check to prevent accidental deployment to non-Kind clusters * `sanity-check.sh`: Post-deploy verification including rollout status, TLS handshake (webhook), HTTP health endpoints, and Istio gateway routing for backend and frontend * `gateway.yaml`: Istio Gateway (HTTP + HTTPS) for kubeflow-gateway * `gateway-cert.yaml`: Self-signed ClusterIssuer and Certificate for gateway TLS termination * Makefile targets: setup-cluster, deploy-all, sanity-check, teardown-cluster, clean, and local-e2e (placeholder) - Add GitHub Actions workflow (`.github/workflows/ws-e2e-test.yml`): * Triggers on pushes to main branches and PRs affecting workspaces * Pipeline: setup-cluster -> deploy-all -> sanity-check -> local-e2e Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Andy Stoneberg <astonebe@redhat.com> * chore: address PR feedback Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Andy Stoneberg <astonebe@redhat.com> * chore: address PR feedback Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Andy Stoneberg <astonebe@redhat.com> * mathew: 1 Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> * mathew: 2 Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> --------- Signed-off-by: Andy Stoneberg <astonebe@redhat.com> Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> # This is the commit message kubeflow#11: fix: format Go files with gofmt Signed-off-by: Sneha Das <sn2005eha26das@gmail.com> # This is the commit message kubeflow#12: refactor: address reviewer comments, fix inline type duplication and switch tests to gomega framework Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com> # This is the commit message kubeflow#13: fix(test): use http.NoBody and fix import formatting for linter compliance Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com> # This is the commit message kubeflow#14: fix(test): use http.NoBody and fix import formatting for linter compliance Signed-off-by: Sneha Das <154408198+Snehadas2005@users.noreply.github.com>

add CONTRIBUTING.md, pull_request_template.md and ISSUE_TEMPLATE.

d7f0aac

Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>

google-oss-prow Bot requested review from johnugeorge and terrytangyuan May 9, 2024 12:55

google-oss-prow Bot added the size/L label May 9, 2024

thesuperzapper mentioned this pull request May 17, 2024

Add ederign as member kubeflow/internal-acls#681

Merged

jiridanek suggested changes May 24, 2024

View reviewed changes

Comment thread CONTRIBUTING.md Outdated

Comment thread CONTRIBUTING.md

Comment thread CONTRIBUTING.md Outdated

Comment thread CONTRIBUTING.md

Comment thread CONTRIBUTING.md Outdated

jiridanek reviewed May 24, 2024

View reviewed changes

Comment thread .github/ISSUE_TEMPLATE/01_bug_report.yml

ederign and others added 3 commits May 29, 2024 07:03

Update CONTRIBUTING.md

3ccbd1c

Co-authored-by: Jiri Daněk <jdanek@redhat.com>

Update CONTRIBUTING.md

7f8e029

Co-authored-by: Jiri Daněk <jdanek@redhat.com>

Update CONTRIBUTING.md

d8c0946

Co-authored-by: Jiri Daněk <jdanek@redhat.com>

ederign requested a review from jiridanek May 29, 2024 12:08

jiridanek reviewed May 29, 2024

View reviewed changes

Comment thread CONTRIBUTING.md Outdated

jiridanek approved these changes May 29, 2024

View reviewed changes

Update CONTRIBUTING.md

f443f16

Co-authored-by: Jiri Daněk <jdanek@redhat.com> Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>

ederign force-pushed the issue_template branch from 05b91a3 to f443f16 Compare May 29, 2024 12:58

ederign and others added 2 commits May 29, 2024 08:58

Update CONTRIBUTING.md

7af13f2

Co-authored-by: Jiri Daněk <jdanek@redhat.com>

Merge branch 'main' into issue_template

080062d

jiridanek approved these changes May 30, 2024

View reviewed changes

jiridanek reviewed May 30, 2024

View reviewed changes

thesuperzapper added the area/docs area - related to documentation label Jul 18, 2024

thesuperzapper self-assigned this Jul 18, 2024

thesuperzapper modified the milestone: Repo Setup Jul 18, 2024

thesuperzapper added the project/repo-setup label Jul 18, 2024

thesuperzapper changed the title ~~add CONTRIBUTING.md, pull_request_template.md and ISSUE_TEMPLATE.~~ chore: add issue templates and contributing guide Dec 11, 2024

thesuperzapper mentioned this pull request Mar 7, 2025

chore: issue templates + readme updates + common gha #226

Merged

google-oss-prow Bot closed this in #226 Mar 7, 2025

github-project-automation Bot moved this from In Progress to Done in Kubeflow Notebooks Mar 7, 2025

jenny-s51 pushed a commit to jenny-s51/notebooks that referenced this pull request Mar 19, 2025

Merge pull request kubeflow#4 from jenny-s51/pauloWorkspaceCreation-s…

6428826

…tep1 fix(ws): UI fixes for Step 1 of Workspace Creation

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add issue templates and contributing guide#4

chore: add issue templates and contributing guide#4
ederign wants to merge 7 commits into
kubeflow:mainfrom
ederign:issue_template

ederign commented May 9, 2024 •

edited

Loading

Uh oh!

ederign commented May 9, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ederign commented May 29, 2024 •

edited

Loading

Uh oh!

jiridanek May 29, 2024

Uh oh!

jiridanek May 29, 2024

Uh oh!

jiridanek May 29, 2024

Uh oh!

Uh oh!

google-oss-prow Bot commented May 30, 2024

Uh oh!

jiridanek May 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	Thanks for helping make the Kubeflow Notebooks project better!
	Thanks for helping to make the Kubeflow Notebooks project better!


		The contributor's guide

		* shows you where to find the Contributor License Agreement (CLA) that you need

Conversation

ederign commented May 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ederign commented May 9, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ederign commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jiridanek May 29, 2024

Choose a reason for hiding this comment

Uh oh!

jiridanek May 29, 2024

Choose a reason for hiding this comment

Uh oh!

jiridanek May 29, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

google-oss-prow Bot commented May 30, 2024

Uh oh!

jiridanek May 30, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ederign commented May 9, 2024 •

edited

Loading

ederign commented May 29, 2024 •

edited

Loading