Skip to content

feat: move shared Spark and Trainer test helpers to kubeflow.common - #701

Open
ChandelAnushka wants to merge 1 commit into
kubeflow:mainfrom
ChandelAnushka:feat/move-shared-test-helpers
Open

feat: move shared Spark and Trainer test helpers to kubeflow.common#701
ChandelAnushka wants to merge 1 commit into
kubeflow:mainfrom
ChandelAnushka:feat/move-shared-test-helpers

Conversation

@ChandelAnushka

Copy link
Copy Markdown

What this PR does / why we need it:

Moves shared test utilities (TestCase, SUCCESS, FAILED, DEFAULT_NAMESPACE,
TIMEOUT, RUNTIME) from kubeflow.trainer.test.common and
kubeflow.spark.test.common into a new kubeflow.common.testing module.

Updates all 15 test files across trainer, spark, optimizer, hub, and common to import
from the shared location. Original modules are kept as thin re-export shims for
backward compatibility. Spark-specific constants (SPARK_CONNECT_*) remain in
kubeflow.spark.test.common.

Which issue(s) this PR fixes:

Fixes #700

Checklist:

  • Docs included if any changes are user facing
    • N/A — internal test utilities only, no user-facing changes

@google-oss-prow
google-oss-prow Bot requested review from fege and szaher August 1, 2026 07:34
@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign astefanutti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

🎉 Welcome to the Kubeflow SDK! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards
  • Our team will review your PR soon! cc @kubeflow/kubeflow-sdk-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

@ChandelAnushka
ChandelAnushka force-pushed the feat/move-shared-test-helpers branch 2 times, most recently from b9b3550 to 8806a91 Compare August 1, 2026 07:39
Move TestCase, SUCCESS, FAILED, DEFAULT_NAMESPACE, TIMEOUT, and RUNTIME
from kubeflow.trainer.test.common and kubeflow.spark.test.common into a
shared kubeflow.common.testing module. Update all 15 test files to import
from the new location. Original modules are kept as thin re-export shims
for backward compatibility.

Closes kubeflow#700

Signed-off-by: Anushka Chandel <chandelanushka99@gmail.com>
@ChandelAnushka
ChandelAnushka force-pushed the feat/move-shared-test-helpers branch from 8806a91 to db167b3 Compare August 1, 2026 07:41
@ChandelAnushka

Copy link
Copy Markdown
Author

/cc @andreyvelich @Goku2099

@google-oss-prow
google-oss-prow Bot requested a review from andreyvelich August 1, 2026 07:44
@google-oss-prow

Copy link
Copy Markdown
Contributor

@ChandelAnushka: GitHub didn't allow me to request PR reviews from the following users: Goku2099.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @andreyvelich @Goku2099

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ChandelAnushka

Copy link
Copy Markdown
Author

cc @Goku2099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move shared Spark and Trainer test helpers to kubeflow.common

1 participant