feat: move shared Spark and Trainer test helpers to kubeflow.common - #701
feat: move shared Spark and Trainer test helpers to kubeflow.common#701ChandelAnushka wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
b9b3550 to
8806a91
Compare
Move TestCase, SUCCESS, FAILED, DEFAULT_NAMESPACE, TIMEOUT, and RUNTIME from kubeflow.trainer.test.common and kubeflow.spark.test.common into a shared kubeflow.common.testing module. Update all 15 test files to import from the new location. Original modules are kept as thin re-export shims for backward compatibility. Closes kubeflow#700 Signed-off-by: Anushka Chandel <chandelanushka99@gmail.com>
8806a91 to
db167b3
Compare
|
@ChandelAnushka: GitHub didn't allow me to request PR reviews from the following users: Goku2099. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
cc @Goku2099 |
What this PR does / why we need it:
Moves shared test utilities (
TestCase,SUCCESS,FAILED,DEFAULT_NAMESPACE,TIMEOUT,RUNTIME) fromkubeflow.trainer.test.commonandkubeflow.spark.test.commoninto a newkubeflow.common.testingmodule.Updates all 15 test files across trainer, spark, optimizer, hub, and common to import
from the shared location. Original modules are kept as thin re-export shims for
backward compatibility. Spark-specific constants (
SPARK_CONNECT_*) remain inkubeflow.spark.test.common.Which issue(s) this PR fixes:
Fixes #700
Checklist: