Skip to content

Check both v1beta1 and v1alpha1 instance types#2038

Merged
kubermatic-bot merged 1 commit into
kubermatic:mainfrom
mohamed-rafraf:v1beta1
May 26, 2026
Merged

Check both v1beta1 and v1alpha1 instance types#2038
kubermatic-bot merged 1 commit into
kubermatic:mainfrom
mohamed-rafraf:v1beta1

Conversation

@mohamed-rafraf

@mohamed-rafraf mohamed-rafraf commented May 26, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

defaultVMInstanceType only queried v1alpha1 instance type objects. We added v1beta1 to ensure that it works for both api versions

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 26, 2026

@buraksekili buraksekili left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2026
@kubermatic-bot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 73581dd58d01160c7f7efa76306801563a40035c

@kubermatic-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buraksekili

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2026
@mohamed-rafraf

Copy link
Copy Markdown
Member Author

/cherrypick release/v1.65

@kubermatic-bot

Copy link
Copy Markdown
Contributor

@mohamed-rafraf: once the present PR merges, I will cherry-pick it on top of release/v1.65 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release/v1.65

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot merged commit 14a2e77 into kubermatic:main May 26, 2026
12 checks passed
@kubermatic-bot

Copy link
Copy Markdown
Contributor

@mohamed-rafraf: new pull request created: #2039

Details

In response to this:

/cherrypick release/v1.65

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants