label machines metric with kubelet version #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey @multi-io, thanks for the pull! Generally speaking this looks fine, but please be aware that we currently have an open PR #270 which will change the way we collect machine-controller metrics to be mostly stateless and we want that to go in first before we do further changes in the metrics, hence this will have to wait a moment and most likely needs a rebase then. |
Contributor
Author
|
I see @alvaroaleman . Thanks for the update. I'll wait for #270, then. :) |
Contributor
Contributor
Author
|
Great, thanks. I'll rebase tonight when I have time. |
multi-io
force-pushed
the
machines_metric_kubelet_label
branch
from
224a0ef to
fad5ab0
Compare
multi-io
force-pushed
the
machines_metric_kubelet_label
branch
from
fad5ab0 to
523ffad
Compare
Contributor
Author
|
"Tonight" became next week, but here it is. |
alvaroaleman
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds a
kubelet_versionlabel to themachine_controller_machinesPrometheus metric, making it more useful for getting a quick overview of installed machine versions in running clusters.Special notes for your reviewer: