Skip to content

label machines metric with kubelet version #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2018
Merged

label machines metric with kubelet version #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions pkg/controller/machine/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func NewMachineCollector(lister v1alpha1.MachineLister) *MachineCollector {
machines: prometheus.NewDesc(
metricsPrefix+"machines",
"The number of machines managed by this machine controller",
nil, nil,
[]string{"kubelet_version"}, nil,
),
machineCreated: prometheus.NewDesc(
metricsPrefix+"machine_created",
Expand All @@ -71,11 +71,7 @@ func (mc MachineCollector) Collect(ch chan<- prometheus.Metric) {
return
}

ch <- prometheus.MustNewConstMetric(
mc.machines,
prometheus.GaugeValue,
float64(len(machines)),
)
machinesCountByKubeletVersion := make(map[string]uint)

for _, machine := range machines {
ch <- prometheus.MustNewConstMetric(
Expand All @@ -93,5 +89,16 @@ func (mc MachineCollector) Collect(ch chan<- prometheus.Metric) {
machine.Name,
)
}

machinesCountByKubeletVersion[machine.Spec.Versions.Kubelet]++;
}

for version, count := range machinesCountByKubeletVersion {
ch <- prometheus.MustNewConstMetric(
mc.machines,
prometheus.GaugeValue,
float64(count),
version,
)
}
}