Skip to content

Conversation

@ryanjbaxter
Copy link

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2024
@ryanjbaxter
Copy link
Author

@brendanburns @yue9944882 our latest release of Spring Cloud Kubernetes is using 19.0.x branch of the Kubernetes Java Client and is compatible with Spring Boot 3.4.0. Spring Boot 3.4.0 uses GSON 2.11.0 and some users are running into some compatibility issues, see spring-cloud/spring-cloud-kubernetes#1805. We can't update to the latest Kubernetes Java Client which uses GSON 2.11.0 because that would break compatibility and we can't do that until our next major.

Ideally we can upgrade the version of GSON in the 19.x branch and do a release to eliminate the incompatibility.

@ryanjbaxter
Copy link
Author

@brendanburns seems like an issue with the build configuration?

@brendandburns
Copy link
Contributor

I think you may need to backport this fix also:

e931ce8

MacOS + GitHub Actions no longer supports Java8

(cherry picked from commit e931ce8)
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2024
@ryanjbaxter
Copy link
Author

@brendandburns done, can we kick off the build again?

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ryanjbaxter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9c885b7 into kubernetes-client:release-19 Dec 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants