Skip to content

Conversation

@Leo7654
Copy link
Contributor

@Leo7654 Leo7654 commented Nov 12, 2019

No description provided.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 12, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @Leo7654!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 12, 2019
@brendandburns
Copy link
Contributor

@Leo7654 this looks good to me, but unfortunately even for a PR this small we need a signed CLA.

Thanks!

@Leo7654
Copy link
Contributor Author

Leo7654 commented Nov 13, 2019

I signed it

@brendandburns
Copy link
Contributor

Hrm, somehow it's not registering. Do you have the same email on your github account as you registered?

@Leo7654
Copy link
Contributor Author

Leo7654 commented Nov 15, 2019

I signed it

@Leo7654 Leo7654 closed this Nov 15, 2019
@Leo7654 Leo7654 reopened this Nov 15, 2019
@Leo7654 Leo7654 closed this Nov 15, 2019
@Leo7654 Leo7654 reopened this Nov 15, 2019
@Leo7654
Copy link
Contributor Author

Leo7654 commented Nov 15, 2019

I signed it

@drubin
Copy link
Contributor

drubin commented Nov 15, 2019

Hi @Leo7654 it doesn't seem to be registering. I think if you try step 3. in this doc it might help https://github.com/kubernetes/community/blob/master/CLA.md

@Leo7654 Leo7654 closed this Nov 19, 2019
@Leo7654 Leo7654 reopened this Nov 19, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 19, 2019
@Leo7654
Copy link
Contributor Author

Leo7654 commented Nov 19, 2019

@drubin @brendanburns Thanks! It seems to work!

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, Leo7654

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2109605 into kubernetes-client:master Nov 19, 2019
@drubin
Copy link
Contributor

drubin commented Nov 19, 2019

@Leo7654 it's a pleasure! Thanks for your first contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants