[Query] Code Consistent Check

[codevulture]

Query1)
It would be consistent if :
https://github.com/kubernetes-client/python-base/blob/7c8e59b58d9a769f1ca3f818aa91c8a6538b51b1/config/incluster_config.py#L73-L77

would be implemented similar to :
https://github.com/kubernetes-client/python-base/blob/7c8e59b58d9a769f1ca3f818aa91c8a6538b51b1/config/incluster_config.py#L65

Is there any specific reason for the same?

Query2)
https://github.com/kubernetes-client/python-base/blob/7c8e59b58d9a769f1ca3f818aa91c8a6538b51b1/config/incluster_config.py#L30 why is '%' check used?

[mbohlool]

For 2) we followed golang's implementation here: https://golang.org/pkg/net/#JoinHostPort
To the actual reason it is '%' too, somebody should dig more.

[iamneha]

For 1) The purpose of doing this way because we are using self.token here

I believe there is no code consistency issue here.
@roycaihw can you please confirm and close this issue

[roycaihw]

@iamneha I think you're right.

What we are doing here is

• verifying in-cluster kubeconfig files, which are token file and cert file
• passing them to swagger-generated Configuration object, which requires ssl_ca_cert as a file name, and api_key as a token string.

that's why for token file we read the content and for cert file we passed the file name.