Unit tests leaking thread pools

[amoralej]

Unit tests in kubernetes python client don't terminate the pools in tearDown. This makes them to fail when running in specific environments with lower limits as 32bit systems, with errors like:

error: can't start new thread

I've tested it adding pools termination in unit tests and it worked fine, however i understand unit tests are generated automatically with swagger, so i'm not sure what's the right way to propose patches here.

[zhusichuang]

I have the same issue.

api = core_v1_api.CoreV1Api()
resp = stream(api.connect_get_namespaced_pod_exec, name, 'default',
              command=exec_command,
              stderr=True, stdin=False,
              stdout=True, tty=False)
api = None

The first line code will produce about 59 threads, but after I call the exec api and make the api variable be None ,the 59 threads still be alive in my process.

[amoralej]

I think the right fix is add api _client pools terminate in tearDown for each test.

[roycaihw]

This is a known issue. Please see #411. @amoralej The tests are generated using swagger-codegen: https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/main/resources/python/api_test.mustache, please feel free to patch the upstream generator.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

Details

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.