This repository was archived by the owner on Dec 3, 2024. It is now read-only.
Fix build #28
Closed
Fix build #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to snapshot-controller v3.0.0
Bazel makes sense in the Prow jobs because those often get invoked with a pre-populated Bazel cache. But local invocation don't need it and now can turn it off with CSI_PROW_USE_BAZEL=false.
kind 0.9 adds support for recent Kubernetes releases like 1.19 and simplifies configuration of feature gates and runtime config. With Kubernetes 1.19, new feature gates were introduced which might become relevant for the alpha Prow jobs. The updated kind release comes with images for different Kubernetes releases than the one before. To avoid breaking existing jobs, the script now picks kind images automatically. As an additional bonus, it then uses images with hash, i.e. it's less likely to break if those image tags change because of a future kind release.
prow.sh: update to kind 0.9, support Kubernetes 1.19
Add go ldflags using LDFLAGS at the time of compilation
Commit 7bcee13 added alpha feature gates for Kubernetes 1.19 in the CSI_PROW_E2E_ALPHA_GATES_LATEST variable based on the comment in kubernetes-csi/external-provisioner#493 (comment) that alpha testing only runs for the latest Kubernetes. But some components (like external-health-monitor) are configured with a single Prow job which runs the default set of tests on a stable Kubernetes release (currently 1.17). Those tests used to include alpha testing which then broke during Kind cluster startup because the Kubernetes 1.19 feature gates weren't recognized by 1.17. The solution is to disable alpha testing for Kubernetes != latest in the default set of tests.
Kind 0.9.0 accesses the "bazel-out" directory with a relative path, which only works when the command is invoked inside the Kubernetes source code directory (kubernetes-sigs/kind#1910).
…uild-workaround prow.sh: work around "kind build node-image" failure
prow.sh: only run alpha tests for latest Kubernetes release
…hot_v1_rc Update snapshot CRD version
This PR installs snapshot CRDs and rbac rules from the repo and installs snapshot controller from a local image if it is a PR in external-snapshotter repo. Otherwise it uses main or a stable version.
…shot_controller Fix the install of snapshot CRDs and controller
revert part of change
…e-name allow export registry name
Builds of external-snapshotter sometimes timed out because it builds three images and that takes almost half an hour (the previous limit) and more if the network is slow. There's no good way to set timeouts per repo and a too high timeout for shouldn't cause any issue, therefore the timeout gets increased everywhere.
cloud build: double the timeout, now 1 hour
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mkumatag The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XXL
|
/cc @brahmaroutu |
|
@mkumatag Please do not copy release-tools, Makefile fetches release-tools and we should just checkin a cloud build yaml. |
brahmaroutu
reviewed
Dec 28, 2020
| $(shell cp -r ${TMP}/container-object-storage-interface-spec/release-tools ${CURDIR}/) | ||
| $(shell rm -rf ${TMP}) | ||
| ln -s release-tools/travis.yml travis.yml | ||
| .PHONY: all cosi-controller-manager clean test |
There was a problem hiding this comment.
We will copy release-tools from spec.
| @@ -0,0 +1 @@ | |||
| ./release-tools/cloudbuild.yaml No newline at end of file | |||
There was a problem hiding this comment.
Can this file be maintained for the repo?
|
needs a major rebase. Closing until that is done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17
This PR reuses the build tools present in the csi-release-tools repository helps to build and push both binaries and the container images.
Followed the instructions mentioned here: https://github.com/kubernetes-csi/csi-release-tools#sharing-and-updating