This repository was archived by the owner on May 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 261
Enable LeaderElect for both scheduler and controller #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k82cn
reviewed
Jul 24, 2018
cmd/kar-controllers/app/server.go
Outdated
| <-stopCh | ||
| } | ||
|
|
||
| if opt.EnableLeaderElection { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be if not
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, updated
k82cn
reviewed
Jul 24, 2018
cmd/kar-scheduler/app/server.go
Outdated
| <-stopCh | ||
| } | ||
|
|
||
| if opt.EnableLeaderElection { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Contributor
|
thanks for your contribution, merged it :) |
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Enable LeaderElect for both scheduler and controller
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Enable LeaderElect for both scheduler and controller
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Enable LeaderElect for both scheduler and controller
asifdxtreme
added a commit
to asifdxtreme/kubes-sigs-kube-batch
that referenced
this pull request
Jul 15, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 15, 2019
Cherry-Pick #306 from Volcano
asifdxtreme
added a commit
to asifdxtreme/kubes-sigs-kube-batch
that referenced
this pull request
Jul 16, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 16, 2019
Cherry-pick from Volcano #306 to v0.5 branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #299