Skip to content
This repository was archived by the owner on May 25, 2023. It is now read-only.

Conversation

@wackxu
Copy link
Contributor

@wackxu wackxu commented Jul 23, 2018

fix #299

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 23, 2018
<-stopCh
}

if opt.EnableLeaderElection {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be if not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, updated

<-stopCh
}

if opt.EnableLeaderElection {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@k82cn k82cn merged commit 919f9b9 into kubernetes-retired:master Jul 24, 2018
@k82cn
Copy link
Contributor

k82cn commented Jul 24, 2018

thanks for your contribution, merged it :)

@wackxu wackxu deleted the leaderelect branch July 27, 2018 08:32
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
Enable LeaderElect for both scheduler and controller
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
Enable LeaderElect for both scheduler and controller
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
Enable LeaderElect for both scheduler and controller
asifdxtreme added a commit to asifdxtreme/kubes-sigs-kube-batch that referenced this pull request Jul 15, 2019
k8s-ci-robot added a commit that referenced this pull request Jul 15, 2019
asifdxtreme added a commit to asifdxtreme/kubes-sigs-kube-batch that referenced this pull request Jul 16, 2019
k8s-ci-robot added a commit that referenced this pull request Jul 16, 2019
Cherry-pick from Volcano #306 to v0.5 branch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable LeaderElect for both scheduler and controller

3 participants