-
Notifications
You must be signed in to change notification settings - Fork 96
fix: snapshot restore and volume clone failure in some new sovereign … #2249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: snapshot restore and volume clone failure in some new sovereign … #2249
Conversation
|
Welcome @hasethuraman! |
|
Hi @hasethuraman. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/retest |
andyzhangx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, hasethuraman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-1.27 |
|
/cherrypick release-1.26 |
|
@andyzhangx: new pull request created: #2251 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@andyzhangx: new pull request created: #2252 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
We use azcopy during volume clone. Azcopy trusts known Microsoft's endpoint suffixes. When a new endpoint is added, AzCopy fails saying it is not trustable & so volume provisioning fails. Since Azure File CSI Driver knows the trusted new endpoint through the config & in such case if the new endpoint is not in azcopy known list, we will use the option that azcopy provides to pass new suffixes
Without this PR, we need to release new version until which the volume clone is not possible
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: