Don't emit Prune event for NoMatchError #338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing prune has a bug when handling the following case:
Since the CR doesn't exist in step 5, we actually don't need to trigger the deletion for it. Emitting the PruneEvent with an error doesn't make sense either. It only needs to remove the GKNN of the CR from the inventory list, which is already done by the current code.
This PR checks if the error from step 5 is a NoMatchError. It it is, continue to the next object.