🌱 Better error message when metadata.yaml might be out of date.

[guettli]

What this PR does / why we need it:

If you do not update metadata.yaml, you might get a hard-to-understand error message in e2e tests (and other places):

failed to find releases tagged with a valid semantic version number

Related: #10332 (comment)

This PR adds:

(metadata.yaml up-to-date?)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chrischdi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @guettli. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mcbenjemaa]

/ok-to-test

[mcbenjemaa]

/area clusterctl

[chrischdi]

It's not always out of date, it could be simply that this provider version is not compatible with the chosen capi version.

I'd guess the metadata misses the version thing only happens in one of these three cases? and the message might be misleading in the two cases where we would return it but its unrelated?!

[guettli]

If you are new to that, then it is likely that you do not know about metadata.yaml.

What about just adding (metadata.yaml)?

But overall it is now no longer very important for me. I just care for other people which are new to that topic.

We can close the PR, if we do not find a simple solution. Maybe this PR (even it is just closed and not merged) helps people to find the right answer :-)

[guettli]

As @chrischdi said, there are several reasons why this could happen. I close the PR. Maybe the closed PR helps developers to understand one reason for that error message.