-
Notifications
You must be signed in to change notification settings - Fork 1.4k
⚠️ Cleanup old function from e2e test framework and helpers #3742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Cleanup old function from e2e test framework and helpers #3742
Conversation
|
@fabriziopandini: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
None of the func being deleted in this PR is used in CAPV |
|
api diff |
|
lgtm for capa, given kubernetes-sigs/cluster-api-provider-aws#2012 |
cpanato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for others to review
yastij
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR removes functions from the e2e test framework and helpers that should not be necessary anymore for the projects switched to using clusterctl utils for tests
#Which issue(s) this PR fixes:
Rif #3689
/assign @vincepri
/milestone v0.4.0
/hold
while doing a double check on the codebase of few providers
FYI @randomvariable @yastij @nader-ziada