Skip to content

Conversation

@fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR removes functions from the e2e test framework and helpers that should not be necessary anymore for the projects switched to using clusterctl utils for tests

#Which issue(s) this PR fixes:
Rif #3689

/assign @vincepri
/milestone v0.4.0

/hold
while doing a double check on the codebase of few providers
FYI @randomvariable @yastij @nader-ziada

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Oct 5, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2020
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 5, 2020
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff-main d2ff718 link /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fabriziopandini
Copy link
Member Author

/cc @CecileRobertMichon

@benmoss
Copy link

benmoss commented Oct 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2020
@fabriziopandini
Copy link
Member Author

@fabriziopandini
Copy link
Member Author

None of the func being deleted in this PR is used in CAPV

@fabriziopandini
Copy link
Member Author

@fabriziopandini
Copy link
Member Author

api diff

sigs.k8s.io/cluster-api/test/helpers/kind
  - Cluster: removed
sigs.k8s.io/cluster-api/test/framework/generators
  - CertManager: removed
  - ClusterAPI: removed
  - ClusterAPIGitHubManifestsFormat: removed
  - KubeadmBootstrap: removed
  - KubeadmBootstrapGitHubManifestsFormat: removed
  - KubeadmControlPlane: removed
  - KubeadmControlPlaneGitHubManifestsFormat: removed
sigs.k8s.io/cluster-api/test/helpers/flag
  - DefineOrLookupStringFlag: removed
sigs.k8s.io/cluster-api/test/helpers/components
  - CAPIVersion: removed
  - DeployCAPIComponents: removed
  - WaitDeployment: removed
sigs.k8s.io/cluster-api/test/helpers/scheme
  - SetupScheme: removed

@randomvariable
Copy link
Member

lgtm for capa, given kubernetes-sigs/cluster-api-provider-aws#2012

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for others to review

Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vincepri
Copy link
Member

vincepri commented Oct 6, 2020

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit fdc0632 into kubernetes-sigs:master Oct 6, 2020
@fabriziopandini fabriziopandini deleted the cleanup-e2e-framework-and-helpers branch October 13, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants