Skip to content

Conversation

@tranthang2404
Copy link
Contributor

@tranthang2404 tranthang2404 commented May 12, 2022

What this PR does / why we need it:
Change variable in code to make object created by Cluster Resource Set will follow priority

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6500

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 12, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 12, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @tranthang2404. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 12, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2022
@tranthang2404 tranthang2404 changed the title fix Cluster Resource Set typo 🐛 fix Cluster Resource Set typo May 12, 2022
@tranthang2404 tranthang2404 reopened this May 12, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 12, 2022
@chrischdi
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2022
@sbueringer
Copy link
Member

sbueringer commented May 12, 2022

/retitle 🐛 ClusterResourceSet: apply objects in sorted order

/lgtm

@k8s-ci-robot k8s-ci-robot changed the title 🐛 fix Cluster Resource Set typo 🐛 ClusterResource Set: apply objects in sorted order May 12, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2022
@sbueringer sbueringer changed the title 🐛 ClusterResource Set: apply objects in sorted order 🐛 ClusterResourceSet: apply objects in sorted order May 12, 2022
@chrischdi
Copy link
Member

/lgtm

Thank you for the finding 👍

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sbueringer
Copy link
Member

sbueringer commented May 12, 2022

/approve

Congrats for your first contribution to CAPI!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit edcd75d into kubernetes-sigs:main May 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone May 12, 2022
@fabriziopandini
Copy link
Member

/cherry-pick release-1.1

@k8s-infra-cherrypick-robot

@fabriziopandini: new pull request created: #6512

In response to this:

/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cluster Resource Set doesn't apply priority follow

7 participants