🐛 Gitlab repository: switch to url.Path instead of url.RawPath

[CharlieR-o-o-t]

What this PR does / why we need it:
For now it's impossible to use non-urlencoded URL with cluster-api gitlab repo client.
After url.Parse call, url.RawPath is used which is optional, and exists only if provided URL has encoded characters.

E.g this url
https://gitlab.foo.com/api/v4/projects/3441/packages/generic/aws-provider/v0.2.34/infrastructure-components.yaml
will result in error
invalid url: a GitLab repository url should be in the form https://{host}/api/v4/projects/{projectSlug}/packages/generic/{packageName}/{defaultVersion}/{componentsPath}

/area clusterctl
area/clusterctl

[k8s-ci-robot]

Hi @CharlieR-o-o-t. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ykakarap for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cmd/clusterctl/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[killianmuldoon]

/area clusterctl
/ok-to-test

Thanks for this! Did you run into this issue with a release version of clusterctl?

[CharlieR-o-o-t]

@killianmuldoon
I'm using cluster-api-operator and cluster-api is vendored. Yes, the problem is actual for release version.

I have noticed that some tests has been failed and found the reason of usage url.RawPath.
URL provided to repository gitlab client is expected to be encoded since "ProjectSlug" should be able to contain path separator characters like "/", in other case url will be parsed incorrectly.

So, it's expected the projectSlug should be always url-encoded.

So, cluster-api gitlab client will not work in case when ProjectID is provided instead of ProjectSlug, this is correct url to access package registry, but invalid in context of cluster-api client.

[Jont828]

@CharlieR-o-o-t This change seems reasonable to me. Did you try this out locally to verify that it works? And second, it looks like you're getting some unit test failures saying that it failed to create the GitLab client.

[CharlieR-o-o-t]

@CharlieR-o-o-t This change seems reasonable to me. Did you try this out locally to verify that it works? And second, it looks like you're getting some unit test failures saying that it failed to create the GitLab client.

hello, I had take a look into unit tests, there is strict test condition that gitlab project expected to be url encoded string. This is why it's failing. There is bunch of unit tests linked to this.

I need some time to rework this. To allow both url encoded and non url-encoded. Will update soon.

[fabriziopandini]

/lgtm

[fabriziopandini]

/lgtm cancel

as per

I need some time to rework this. To allow both url encoded and non url-encoded. Will update soon.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@CharlieR-o-o-t: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-test-main	f201cea	link	true	/test pull-cluster-api-test-main
pull-cluster-api-e2e-blocking-main	f201cea	link	true	/test pull-cluster-api-e2e-blocking-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[fabriziopandini]

/close

as per #10605 (comment)

[k8s-ci-robot]

@fabriziopandini: Closed this PR.

In response to this:

/close

as per #10605 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.