Skip to content

Conversation

@kannon92
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Use IntegrationReference instead of strings.

Which issue(s) this PR fixes:

Maybe #4659

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kannon92
Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 19, 2025
@netlify
Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 948a671
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67db662bc3897f0008fb94f3
😎 Deploy Preview https://deploy-preview-4697--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kannon92
Copy link
Contributor Author

/cc @mimowo

#4676 (comment)

@kannon92 kannon92 force-pushed the shift-left-minimal-kueue-changes branch from e38b1d4 to 948a671 Compare March 20, 2025 00:49
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2025
@mimowo
Copy link
Contributor

mimowo commented Mar 20, 2025

Actually, out of the two I prefer this one in #4676 for consistently using IntegrationReference throughout the codebase where applicable.

My comment was about grouping all the integrations in the monolithic style.

Note that, there is no guarantee when adding a new integration to Kueue someone will put it on the new list. It would compile equally well if the constant was declared in the scope of the package for the new integration.
So, I'm honestly not sure what is the benefit, maybe vs-code support to find all references?. Also, as new integrations are added one needs to be always careful to check code for the tag corresponding to the version of Kueue installed. I think the most reliable source of trough is runtime logging, or a utility function exported by Kueue as suggested earlier. Also, other approaches were proposed as loose validation.

I'm open to the possibility, that I'm missing something, but I would like to take a step back and define the problem we are solving. For example, the issue mentions MXJob, which was not in the comments for a good reason, as no longer supported.

And I think there is no need to rush, we can do it post 0.11, and post KubeCon :) .

/hold
cc @tenzen-y

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2025
@kannon92 kannon92 closed this Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants