Add ResourceFlavor specificatios for coupling of nodeTaints and tolerations to documentation #4704
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
|
/hold |
k8s-ci-robot
added
size/S
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
| // When this ResourceFlavor has corresponding .spec.tolerations as those nodeTaints, | ||
| // nodeTaints are not considered during admission. |
There was a problem hiding this comment.
| // When this ResourceFlavor has corresponding .spec.tolerations as those nodeTaints, | |
| // nodeTaints are not considered during admission. | |
| // When this ResourceFlavor has also set the matching tolerations (in .spec.tolerations), | |
| // then the nodeTaints are not considered during admission. |
nit, proposal
There was a problem hiding this comment.
Thanks, that sounds good to me.
k8s-ci-robot
added
the
needs-rebase
|
@tenzen-y Could you please rebase? |
tenzen-y
force-pushed
the
add-rf-nodetaints-couple-specifications
branch
from
ba14352 to
d98fd2f
Compare
k8s-ci-robot
removed
the
needs-rebase
…ations to documentation Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> # Conflicts: # site/content/en/docs/concepts/resource_flavor.md
tenzen-y
force-pushed
the
add-rf-nodetaints-couple-specifications
branch
from
d98fd2f to
ef1b992
Compare
|
@mbobrovskyi I addressed @mimowo comments, and resolve conflicts, thanks. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: 14d8e1f0c1fc7a5c6bec31af7ff7895c156f0f25 |
|
/cherry-pick website |
|
@tenzen-y: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@tenzen-y: new pull request created: #5146 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
What type of PR is this?
/kind documentation
What this PR does / why we need it:
As we discussed in #4646, we want to mention what happens if nodeTains and tolerations are specified in the same ResourceFlavor.
Which issue(s) this PR fixes:
Fixes #4646
Special notes for your reviewer:
Does this PR introduce a user-facing change?