-
Notifications
You must be signed in to change notification settings - Fork 508
Reinvocation policy for mutating webhooks #4715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinvocation policy for mutating webhooks #4715
Conversation
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yuvalaz99 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @yuvalaz99! |
|
Hi @yuvalaz99. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| protocol: TCP | ||
| targetPort: 9443 | ||
| type: ClusterIP | ||
| webhook: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the chart readme to ad this new setting for the values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
|
Please sign the CLA. |
|
/ok-to-test |
|
I think a release note would be useful for this. |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
@yuvalaz99: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds an option in the Helm chart to configure the webhook with
reinvocationPolicy.Currently, Kueue does not explicitly set
reinvocationPolicyin the Helm chart, so it defaults toNever.In setups where workloads require mutation before being handled by Kueue (such as label or resource modifications), Kueue’s webhook may execute before these changes are applied, causing it to ignore those workloads.
By allowing users to configure
reinvocationPolicy, they can set it toIfNeeded, ensuring that the webhook will be reinvoked after other webhooks mutate the object.Which issue(s) this PR fixes:
Fixes #4681
Special notes for your reviewer:
Does this PR introduce a user-facing change?