Skip to content

Conversation

@sipriyaa
Copy link
Contributor

@sipriyaa sipriyaa commented Mar 21, 2025

What this PR does / why we need it:
This PR introduces changes for the Nimbus testbed, allowing deployment on a private network/isolated network, or public network.

In a public network setup, the port numbers for vCenter (VC), Master, Worker VMs, and ESXi remain the same.

In a private network setup, the port numbers vary for each vSphere resource component.

Key changes in this PR include:

Resolving the vCenter address dynamically with its corresponding port number.

Mapping master IPs to their respective port numbers.

Removing hardcoded storage class names.

Reading port numbers and master IPs at runtime.

Dynamically determining the vCenter address (IP + PortNo) based on the specified network type (public or private).

removal of unnecessary duplicate code

Increase in the pvc creation timeout from 1 min to 5 mins

Testing done:
In progress

Special notes for your reviewer:
ps031044@P2XQC4DXP0 vsphere-csi-driver % golangci-lint run --enable=lll
ps031044@P2XQC4DXP0 vsphere-csi-driver % make golangci-lint
hack/check-golangci-lint.sh
golangci/golangci-lint info checking GitHub for tag 'v1.59.1'
golangci/golangci-lint info found version: 1.59.1 for v1.59.1/darwin/arm64
golangci/golangci-lint info installed /Users/ps031044/go/bin/golangci-lint
INFO golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z
INFO [config_reader] Config search paths: [./ /Users/ps031044/public-private-network/vsphere-csi-driver /Users/ps031044/public-private-network /Users/ps031044 /Users /]
INFO [config_reader] Used config file .golangci.yml
INFO [lintersdb] Active 8 linters: [errcheck gosimple govet ineffassign lll misspell staticcheck unused]

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sipriyaa
Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2025
@sipriyaa sipriyaa force-pushed the public-private-network branch from 58fd717 to b71beec Compare March 21, 2025 13:07
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 21, 2025
@sipriyaa sipriyaa force-pushed the public-private-network branch 3 times, most recently from 06b779e to e0287d9 Compare March 22, 2025 13:00
@sipriyaa sipriyaa changed the title [wip] public private nimbus testbed regression testsuite code changes [WIP] Adapt the CSI FvT e2e testsuite code to support new changes for both private network isolated testbeds and public network Nimbus testbeds. Mar 22, 2025
@sipriyaa sipriyaa force-pushed the public-private-network branch 4 times, most recently from f0a01e8 to c249bcf Compare March 24, 2025 07:28
@sipriyaa sipriyaa force-pushed the public-private-network branch from 55b7497 to 02d621f Compare March 24, 2025 09:25
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kirankumarbasavaraju-broadcom
Copy link
Contributor

  1. List all the issues you have addressed here.
  2. Take each issue in different PR and do not merge it in single PR (I see 10-12 issue addressed in this PR)
  3. For now, discard this PR and raise a new PR only for private network test execution.
  4. For private network, read ssh port number from ENV variable at the util and not in the test files or feature specific uitls.
  5. Create a cache for the IP to port in the util and do the lazy reading whenever it is necessary during the execution

@sipriyaa sipriyaa closed this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants