check for nil readytouse value from volumesnapshot status #3236
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @nikhilbarge. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XS
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
nikhilbarge
changed the title
|
/approve |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akankshapanse, nikhilbarge, vdkotkar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
* Update logging for periodic sync feature (#3212) * Update logging for periodic sync feature (#3215) * test fix (#3210) * Fix unnecessary error log in syncer during PodAdded event (#3214) * Remove unused logic from session manager (#3213) * workload management domain isolation automation part2 (#3199) * Refactor tag manager rest client (#3221) * WLDI-Automation: A basic test that creates a stateful set on a shared storage policy is added (#3223) * WCP test fix (#3228) * Added testcase-5 from WLDI feature (#3232) * check for nil readonly from volumesnapshot status (#3236) * Remove hardcoded vmodl version in e2e tests (#3231) Seems use of dev.version with a GA vCenter build prevents PropertyCollector from returning task results from internal methods (such as CnsQuerySnapshots). The e2e/newClient function already calls UseServiceVersion(), which returns the appropriate version when vCenter build is GA/release or dev.version for builds from main. * code review fixes (#3237) --------- Co-authored-by: nikhilbarge <nbarge@vmware.com> Co-authored-by: kavyashree-r <71521316+kavyashree-r@users.noreply.github.com> Co-authored-by: Shalini Bhaskara <sbhaskara@vmware.com> Co-authored-by: Ricardo Katz <rikatz@users.noreply.github.com> Co-authored-by: sipriyaa <93115138+sipriyaa@users.noreply.github.com> Co-authored-by: bn023052 <203637947+bn023052@users.noreply.github.com> Co-authored-by: Doug MacEachern <dougm@broadcom.com>
4 participants
What this PR does / why we need it:
PR intent to handle nil value for VolumeSnapshot Status.ReadyToUse, to fix the code panics.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Testing done:
Manual Testing Performed
Logs:
Before fix:
readytouse_panic_before_fix.log
After Fix
readytouse_panic_fixed.log
Special notes for your reviewer:
Release note: