Initial implementation of subprojects #1674

spiffxp · 2018-01-24T22:04:38Z

Initial implementation of #1673

A subproject is a one-to-many mapping of a name to a list of
OWNERS urls. This allows for a subproject to be a single repo (eg:
helm), or a subproject to be a list of multiple subdirectories across
one or more repos (eg: workloads api)

Strawman assignment of single repo subprojects per an initial mapping
from @bgrant0607

spiffxp · 2018-02-01T20:51:19Z

kubernetes-dev thread

I will merge Tuesday Feb 6th if there are no objections or comments that can't be properly addressed

cblecker · 2018-02-01T20:56:31Z

sig-list.md

 |[Scheduling](sig-scheduling/README.md)|scheduling|* [Bobby (Babak) Salamat](https://github.com/bsalamat), Google<br>* [Timothy St. Clair](https://github.com/timothysc), Heptio<br>|* [Slack](https://kubernetes.slack.com/messages/sig-scheduling)<br>* [Mailing List](https://groups.google.com/forum/#!forum/kubernetes-sig-scheduling)|* Regular SIG Meeting: [Thursdays at 20:00 UTC (biweekly)](https://zoom.us/j/7767391691)<br>
 |[Service Catalog](sig-service-catalog/README.md)|service-catalog|* [Paul Morie](https://github.com/pmorie), Red Hat<br>* [Aaron Schlesinger](https://github.com/arschles), Microsoft<br>* [Ville Aikas](https://github.com/vaikas-google), Google<br>* [Doug Davis](https://github.com/duglin), IBM<br>|* [Slack](https://kubernetes.slack.com/messages/sig-service-catalog)<br>* [Mailing List](https://groups.google.com/forum/#!forum/kubernetes-sig-service-catalog)|* Regular SIG Meeting: [Mondays at 20:00 UTC (weekly)](https://zoom.us/j/7201225346)<br>
 |[Storage](sig-storage/README.md)|storage|* [Saad Ali](https://github.com/saad-ali), Google<br>* [Bradley Childs](https://github.com/childsb), Red Hat<br>|* [Slack](https://kubernetes.slack.com/messages/sig-storage)<br>* [Mailing List](https://groups.google.com/forum/#!forum/kubernetes-sig-storage)|* Regular SIG Meeting: [Thursdays at 9:00 PT (Pacific Time) (biweekly)](https://zoom.us/j/614261834)<br>
-|[Testing](sig-testing/README.md)|testing|* [Aaron Crickenberger](https://github.com/spiffxp), Samsung SDS<br>* [Erick Feja](https://github.com/fejta), Google<br>* [Steve Kuznetsov](https://github.com/stevekuznetsov), Red Hat<br>* [Timothy St. Clair](https://github.com/timothysc), Heptio<br>|* [Slack](https://kubernetes.slack.com/messages/sig-testing)<br>* [Mailing List](https://groups.google.com/forum/#!forum/kubernetes-sig-testing)|* Regular SIG Meeting: [Tuesdays at 13:00 PT (Pacific Time) (weekly)](https://zoom.us/my/k8s.sig.testing)<br>* Testing Commons: [Wednesdays at 07:30 PT (Pacific Time) (bi-weekly)](https://zoom.us/my/k8s.sig.testing)<br>


Should subproject meetings be listed in sig-list.md?

bgrant0607

Good start, thanks!

I see subprojects in the kubernetes repo are mostly missing. I commented on some, but there are more we'll need to add, such as more code in pkg/registry and tests in kubernetes/tests.

SIG Auth includes RBAC and other auth plugins.

bgrant0607 · 2018-02-06T02:52:00Z

sig-api-machinery/README.md

+- **api**
+  - Owners:
+    - https://raw.githubusercontent.com/kubernetes/api/master/OWNERS
+- **apiextensions-apiserver**


Subproject CRD

bgrant0607 · 2018-02-06T02:56:07Z

sig-api-machinery/README.md

+- **apiextensions-apiserver**
+  - Owners:
+    - https://raw.githubusercontent.com/kubernetes/apiextensions-apiserver/master/OWNERS
+- **apimachinery**


I'd group these 3 under the apiserver subproject. Conversion should really only run in the apiserver. But I could see an argument for grouping apimachinery with gengo.

It's worth getting input from @kubernetes/sig-api-machinery-api-reviews how they'd group them.

bgrant0607 · 2018-02-06T02:56:40Z

sig-api-machinery/README.md

+- **apiserver-builder**
+  - Owners:
+    - https://raw.githubusercontent.com/kubernetes-incubator/apiserver-builder/master/OWNERS
+- **client-go**


I'd group all the clients under a client library (or client SDK) subproject.

bgrant0607 · 2018-02-06T03:02:59Z

sig-api-machinery/README.md

+- **gen**
+  - Owners:
+    - https://raw.githubusercontent.com/kubernetes-client/gen/master/OWNERS
+- **gengo**


I'd include gengo in an "IDL" subproject.

bgrant0607 · 2018-02-06T03:03:47Z

sig-api-machinery/README.md

+- **javascript**
+  - Owners:
+    - https://raw.githubusercontent.com/kubernetes-client/javascript/master/OWNERS
+- **kube-aggregator**


API Aggregation subproject

bgrant0607 · 2018-02-06T03:48:30Z

sig-scalability/README.md

+## Subprojects
+
+The following subprojects are owned by this SIG:
+- **perf-tests**


kubemark:
https://github.com/kubernetes/kubernetes/tree/master/cmd/kubemark
https://github.com/kubernetes/kubernetes/tree/master/pkg/kubemark

bgrant0607 · 2018-02-06T03:49:46Z

sig-scheduling/README.md


+## Subprojects
+
+The following subprojects are owned by this SIG:


scheduler:
https://github.com/kubernetes/kubernetes/tree/master/cmd/kube-scheduler
https://github.com/kubernetes/kubernetes/tree/master/pkg/scheduler

bgrant0607 · 2018-02-06T03:52:34Z

sig-storage/README.md


+## Subprojects
+
+The following subprojects are owned by this SIG:


volumes:
https://github.com/kubernetes/kubernetes/tree/master/pkg/volume

bgrant0607 · 2018-02-06T03:54:28Z

sig-testing/README.md

+## Subprojects
+
+The following subprojects are owned by this SIG:
+- **test-infra**


What about test infra in the kubernetes repo, such as parts of https://github.com/kubernetes/kubernetes/tree/master/test/e2e?

bgrant0607 · 2018-02-06T03:55:02Z

sig-windows/README.md

+## Subprojects
+
+The following subprojects are owned by this SIG:
+- **dashboard**


This should be sig-ui rather than sig-windows

mattfarina · 2018-02-06T22:15:34Z

sigs.yaml

+    - name: rudder-federation
+      owners:
+      - https://raw.githubusercontent.com/kubernetes-helm/rudder-federation/master/OWNERS
+    - name: workloads-api


jobs and cronjobs should also be here.

Done, I updated the description and added the OWNERS files for the controllers and the batch api

spiffxp · 2018-02-07T16:28:46Z

I will take a crack at adding the subproject meetings to sig-list.md later today but honestly I think the formatting on that page needs to be re-thought and I don't want to play with it too much in this PR.

A subproject is a one-to-many mapping of a name to a list of OWNERS urls. This allows for a subproject to be a single repo (eg: helm), or a subproject to be a list of multiple subdirectories across one or more repos (eg: workloads api) SIG meetings dedicated to a single subproject moved down to subproject meetings

spiffxp · 2018-02-07T23:39:53Z

/hold cancel
ready for /lgtm

bgrant0607 · 2018-02-07T23:50:31Z

Awesome. Merge and iterate. In the next attempt, I can try to enumerate more of the subprojects in the kubernetes repo.

/lgtm

k8s-ci-robot · 2018-02-07T23:50:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [bgrant0607,spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bgrant0607 · 2018-02-07T23:51:55Z

sig-api-machinery/README.md

+- **crd**
+  - Owners:
+    - https://raw.githubusercontent.com/kubernetes/apiextensions-apiserver/master/OWNERS
+- **gen**


Is this gengo?

No, that's IDL, below

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 24, 2018

k8s-ci-robot requested review from DirectXMan12, adohe-zz, calebamiles, cblecker, countspongebob, csbell, dcbw, dchen1107, fabxc, fejta, foxish, grodrigues3, idvoretskyi, jaredbhatti and jdumars January 24, 2018 22:04

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2018

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 31, 2018

spiffxp force-pushed the sig-ownership-strawman branch 2 times, most recently from a014965 to cfe4fc9 Compare January 31, 2018 23:57

spiffxp force-pushed the sig-ownership-strawman branch from 97aac1f to 9058070 Compare February 1, 2018 20:51

cblecker reviewed Feb 1, 2018

View reviewed changes

bgrant0607 reviewed Feb 6, 2018

View reviewed changes

k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 6, 2018

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2018

mattfarina reviewed Feb 6, 2018

View reviewed changes

spiffxp force-pushed the sig-ownership-strawman branch from 9058070 to f39a792 Compare February 7, 2018 14:58

k8s-github-robot added sig/ui Categorizes an issue or PR as relevant to SIG UI. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 7, 2018

spiffxp force-pushed the sig-ownership-strawman branch from f39a792 to 4764a89 Compare February 7, 2018 16:27

spiffxp added 3 commits February 7, 2018 16:11

update subprojects based on review comments

28584e4

List subproject meetings in sig-list.md

ecd88cf

spiffxp force-pushed the sig-ownership-strawman branch from 4764a89 to ecd88cf Compare February 7, 2018 23:25

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2018

k8s-ci-robot assigned bgrant0607 Feb 7, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2018

k8s-ci-robot merged commit 6a4220c into kubernetes:master Feb 7, 2018

bgrant0607 reviewed Feb 7, 2018

View reviewed changes

spiffxp deleted the sig-ownership-strawman branch February 13, 2018 17:55

neolit123 mentioned this pull request Jul 15, 2020

[REQUEST] Migrate kubernetes-incubator/kube-aws to kubernetes-sigs kubernetes/org#2004

Closed


		## Subprojects

		The following subprojects are owned by this SIG:

Initial implementation of subprojects #1674

Initial implementation of subprojects #1674

Uh oh!

Conversation

spiffxp commented Jan 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spiffxp commented Feb 1, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bgrant0607 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spiffxp commented Feb 7, 2018

Uh oh!

spiffxp commented Feb 7, 2018

Uh oh!

bgrant0607 commented Feb 7, 2018

Uh oh!

k8s-ci-robot commented Feb 7, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

spiffxp commented Jan 24, 2018 •

edited

Loading