Skip to content

KEP for CoreDNS to Default DNS#2167

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
rajansandeep:corednsdefault
Jun 1, 2018
Merged

KEP for CoreDNS to Default DNS#2167
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
rajansandeep:corednsdefault

Conversation

@rajansandeep
Copy link
Copy Markdown
Contributor

@rajansandeep rajansandeep commented May 18, 2018

This KEP is to defined to make CoreDNS the default cluster DNS in Kubernetes.
It is a follow-up to the previous KEP (#1956)

/sig network
/assign @thockin
/assign @bowei

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 18, 2018
@k8s-ci-robot k8s-ci-robot requested review from dcbw and jbeda May 18, 2018 20:25
@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 18, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2018
thockin
thockin reviewed May 24, 2018
View reviewed changes
Comment thread keps/sig-network/0011-20180518-coredns-default-proposal.md
* Make CoreDNS available as an image in a Kubernetes repository (To Be Defined) and ensure a workflow/process to update the CoreDNS versions in the future.
This goal is carried over from the [previous KEP](https://github.com/kubernetes/community/pull/1956), in case it cannot be completed there.

## Proposal
Copy link
Copy Markdown
Member

@thockin thockin May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also want this to encompass the formal deprecation of kube-dns ?

Copy link
Copy Markdown
Member

@thockin thockin May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping

Copy link
Copy Markdown
Member

@johnbelamaric johnbelamaric May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that makes sense. We don't want to maintain two solutions for any longer than necessary.

Copy link
Copy Markdown
Member

@thockin thockin Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I was asking it to be in the doc as a goal. :)

@thockin
Copy link
Copy Markdown
Member

thockin commented May 24, 2018

I'm good with this - anyone else?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2018
krmayankk
krmayankk reviewed May 30, 2018
View reviewed changes
Comment thread keps/sig-network/0012-20180518-coredns-default-proposal.md

* Add CoreDNS image in a Kubernetes repository (To Be Defined) and ensure a workflow/process to update the CoreDNS versions in the future.
* Have a certain number (To Be Defined) of clusters of significant size (To Be Defined) adopting and running CoreDNS as their default DNS.

Copy link
Copy Markdown

@krmayankk krmayankk May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have migration scripts to provide a migration from kubedns configs to coredns ?

Copy link
Copy Markdown
Contributor Author

@rajansandeep rajansandeep May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krmayankk this is already implemented from Kubernetes 1.10 for kubeadm.

Copy link
Copy Markdown

@fturib fturib May 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krmayankk : that is already provided through 'kubeadm upgrade' tool. Are you thinking something else ?

@thockin
Copy link
Copy Markdown
Member

thockin commented Jun 1, 2018

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 1, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2018
@k8s-ci-robot k8s-ci-robot merged commit cf54b34 into kubernetes:master Jun 1, 2018
calebamiles pushed a commit to calebamiles/community that referenced this pull request Sep 5, 2018
@k8s-ci-robot
Merge pull request kubernetes#2167 from rajansandeep/corednsdefault
332f809 
KEP for CoreDNS to Default DNS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@jbeda jbeda Awaiting requested review from jbeda

4 more reviewers

@thockin thockin thockin left review comments

@johnbelamaric johnbelamaric johnbelamaric left review comments

@krmayankk krmayankk krmayankk left review comments

@fturib fturib fturib left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bowei bowei

@thockin thockin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rajansandeep @thockin @k8s-ci-robot @johnbelamaric @krmayankk @fturib @bowei