Volume plugin tests #2272
Volume plugin tests #2272
Conversation
k8s-ci-robot
added
sig/storage
k8s-ci-robot
added
kind/design
|
@BenTheElder FYI, this is another attempt to increase test coverage in storage. This is something different than |
|
Proposal to add a new flag to e2e.go seems simpler then requiring every test to hard code it. If sig-test approves remove hold and merge. |
k8s-ci-robot
added
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saad-ali The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| * Runs the tests with `e2e.test --deploy-storage-utilities` to deploy the mount utilities for kubelet in containers. | ||
| * Runs all storage tests with: `--ginkgo.focus=[sig-storage] --ginkgo.skip=[Distruptive]|[Flaky]|[Serial]|[Feature:<all features except Volumes>]`. | ||
| * This naturally includes `[Slow]`. See below for experimental run results. | ||
| * We want `[Feature:Volumes]` in and all other `[Feature:.*]` out. |
There was a problem hiding this comment.
We may just need to explicitly exclude volume alpha features (like Block)
There was a problem hiding this comment.
They have different tag, e.g. [Feature:BlockVolume], that gets caught by --ginkgo.skip=...|[Feature:<all features except Volumes>].
| * Ubuntu is used to get all necessary kernel modules. COS does not ship them. | ||
| * `MountContainers` alpha feature allows kubelet to run mount utilities in containers instead on the host. | ||
| * Runs the tests with `e2e.test --deploy-storage-utilities` to deploy the mount utilities for kubelet in containers. | ||
| * Runs all storage tests with: `--ginkgo.focus=[sig-storage] --ginkgo.skip=[Distruptive]|[Flaky]|[Serial]|[Feature:<all features except Volumes>]`. |
There was a problem hiding this comment.
Should we also add 2 more jobs that:
- Run [Serial] + [Disruptive] tests
- Run alpha features
There was a problem hiding this comment.
Sure. Note that there are no [Disruptive] or [Serial] tests for iSCSI or Ceph and the rest of [Disruptive] or [Serial] are tested in other jobs (I hope). We may add the new storage jobs when we have the tests.
|
@timstclair @kubernetes/sig-testing-pr-reviews PTAL |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
|
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
I want to introduce a new e2e test job that will include all existing storage tests, including iSCSI, Ceph RBD and Ceph FS. We have tests for them, but they don't run in any e2e job because COS and Ubuntu used as base images does not have necessary utilities.
/sig storage
/sig testing